Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More simple formatting #101878

Merged
merged 1 commit into from
Sep 17, 2022
Merged

More simple formatting #101878

merged 1 commit into from
Sep 17, 2022

Conversation

Rageking8
Copy link
Contributor

No description provided.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 16, 2022
@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 16, 2022
@Rageking8
Copy link
Contributor Author

Rageking8 commented Sep 16, 2022 •
edited
Loading

1 hour+ for CI ?

Edit: CI seems stuck

Edit: CI auto canceled after 6hrs

@lcnr
Copy link
Contributor

lcnr commented Sep 16, 2022

thanks 👍

please try to not make too many prs for internal formatting changes in the futrue. These tend to not have too much of a meaningful impact on people working on rustc while at the same time being somewhat prone to causing merge conflicts which interrupts the work of other contributors.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 16, 2022

📌 Commit d433efa has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2022
@Rageking8
Copy link
Contributor Author

thanks 👍

please try to not make too many prs for internal formatting changes in the futrue. These tend to not have too much of a meaningful impact on people working on rustc while at the same time being somewhat prone to causing merge conflicts which interrupts the work of other contributors.

@bors r+ rollup

Understood. Thanks.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 16, 2022
@GuillaumeGomez
Rollup merge of rust-lang#101878 - Rageking8:More-simple-formatting, …
4ffc06a 
…r=lcnr

More simple formatting
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 16, 2022
Closed
@notriddle notriddle mentioned this pull request Sep 17, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 17, 2022
@bors
Auto merge of rust-lang#101928 - notriddle:rollup-pexhhxe, r=notriddle
4a12d10 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#101340 (Adding Fuchsia zxdb debugging walkthrough to docs)
 - rust-lang#101741 (Adding needs-unwind arg to applicable compiler ui tests)
 - rust-lang#101782 (Update `symbol_mangling` diagnostics migration)
 - rust-lang#101878 (More simple formatting)
 - rust-lang#101898 (Remove some unused CSS rules)
 - rust-lang#101911 (rustdoc: remove no-op CSS on `.source .content`)
 - rust-lang#101914 (rustdoc-json-types: Document that ResolvedPath can also be a union)
 - rust-lang#101921 (Pass --cfg=bootstrap for rustdoc for proc_macro crates)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8b88370 into rust-lang:master Sep 17, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Rageking8 @rust-highfive @lcnr @bors @rustbot