Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to previous type folding behaviour in an attempt to fix a perf regression #101886

Closed
wants to merge 1 commit into from

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Sep 16, 2022

Regression occurred in #101858 (comment)

r? @nnethercote

I knew I did a functional change here, but it just seemed wrong to not fold or visit the Ty<'tcx> inside. Let's see if this fixes the perf regression and then we can reevaluate whether the behaviour is correct

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 16, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 16, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented Sep 16, 2022

@bors try @rust-timer queue include=diesel,ctfe-stress-5,tuple-stress

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 16, 2022
@bors
Copy link
Contributor

bors commented Sep 16, 2022

⌛ Trying commit 8f2fe0f with merge edaec43dbd4ba386300184b22707065380200a20...

@bors
Copy link
Contributor

bors commented Sep 16, 2022

☀️ Try build successful - checks-actions
Build commit: edaec43dbd4ba386300184b22707065380200a20 (edaec43dbd4ba386300184b22707065380200a20)

@rust-timer
Copy link
Collaborator

Queued edaec43dbd4ba386300184b22707065380200a20 with parent 0ee5a1a, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (edaec43dbd4ba386300184b22707065380200a20): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 16, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented Sep 16, 2022

damn, that wasn't it.

@oli-obk oli-obk closed this Sep 16, 2022
@oli-obk oli-obk deleted the lift_derive branch September 16, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants