Rollup of 7 pull requests #101895

GuillaumeGomez · 2022-09-16T11:07:20Z

Successful merges:

rustdoc mobile: move notable traits to return type #101494 (rustdoc mobile: move notable traits to return type)
Extend CSS check to CSS variables #101813 (Extend CSS check to CSS variables)
Fix back RPIT changes #101825 (Fix back RPIT changes)
Suggest associated const for incorrect use of let in traits #101843 (Suggest associated const for incorrect use of let in traits)
Slight vertical formatting #101859 (Slight vertical formatting)
rustdoc: use more precise URLs for jump-to-definition links #101868 (rustdoc: use more precise URLs for jump-to-definition links)
rustdoc: remove no-op CSS .block { padding: 0 } #101877 (rustdoc: remove no-op CSS .block { padding: 0 })

Failed merges:

r? @ghost
@rustbot modify labels: rollup

These were originally on the left, but were moved to the return type in c90fb71. The CSS rule for mobile did not get updated at the time, so updating it now.

…binder_api_changes, r=oli-obk" This reverts commit 953a6b3, reversing changes made to b5ffbd3.

…et in traits

As an example, this cuts down <https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_middle/ty/mod.rs.html> by about 11%. $ du -h new_mod.rs.html old_mod.rs.html 296K new_mod.rs.html 332K old_mod.rs.html

This rule was changed in 8fb1250 from the original version that had a non-zero padding. It's not needed, because it's not overriding anything that would've given `.block` a padding.

…aumeGomez rustdoc mobile: move notable traits to return type These were originally on the left, but were moved to the return type in c90fb71. The CSS rule for mobile did not get updated at the time, so updating it now. r? `@notriddle`

…, r=notriddle Extend CSS check to CSS variables This PR is a bit big because the first commit is a rewrite of the CSS parser to something a bit simpler which still allows to get easily access to CSS properties name. The other two are about adding tests and adding the CSS variables check. This check was missing because we are relying more and more on CSS variables rather than CSS selectors in themes. r? `@notriddle`

…-obk Fix back RPIT changes r? `@oli-obk` cc `@compiler-errors`

Suggest associated const for incorrect use of let in traits Fixes rust-lang#101797

…ng, r=compiler-errors Slight vertical formatting

…mp-to-definition, r=GuillaumeGomez rustdoc: use more precise URLs for jump-to-definition links As an example, this cuts down <https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_middle/ty/mod.rs.html> by about 11%. $ du -h new_mod.rs.html old_mod.rs.html 296K new_mod.rs.html 332K old_mod.rs.html Like rust-lang#83237, but separate code since source links have a different URL structure. Related to [Zulip discussion](https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/RFC.20for.20.22jump.20to.20definition.22.20feature/near/299029786) and [the jump-to-definition pre-RFC](GuillaumeGomez/rfcs#1).

…-DPC rustdoc: remove no-op CSS `.block { padding: 0 }` This rule was changed in 8fb1250 from the original version that had a non-zero padding. It's not needed, because it's not overriding anything that would've given `.block` a padding.

GuillaumeGomez · 2022-09-16T11:07:40Z

@bors r+ p=5 rollup=never

bors · 2022-09-16T11:07:42Z

📌 Commit e284393 has been approved by GuillaumeGomez

It is now in the queue for this repository.

bors · 2022-09-16T12:43:25Z

⌛ Testing commit e284393 with merge 54f20bb...

bors · 2022-09-16T16:46:07Z

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 54f20bb to master...

rust-timer · 2022-09-16T16:48:23Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#101877	2ba03325374d9a79465568f48abfb40db0f95c34
#101868	55e8ff0907e4346507e9b8550b31ca7562ccc96d
#101859	f90fa9afa9c8ca5b013f388ce8687e888de68287
#101843	6846054543a5cdffa4d59f8ef8626f892c64b19a
#101825	60031ec14760a98db2bcfd09df199cad767d9c45
#101813	bf4a5a9d7f6fbd0bf1675172c483bc0ba15e1b7f
#101494	c3f2386755e8834c2d413e66c56101b36fabfe16

previous master: 2d1aa57d1e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2022-09-16T18:25:48Z

Finished benchmarking commit (54f20bb): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.5%	[0.5%, 0.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	4.4%	[4.4%, 4.4%]	1
Regressions ❌ (secondary)	4.6%	[2.0%, 7.2%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	4.4%	[4.4%, 4.4%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.1%	[2.1%, 2.1%]	1

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

jsha and others added 22 commits September 6, 2022 10:49

rustdoc mobile: move notable traits to return type

d6f385f

These were originally on the left, but were moved to the return type in c90fb71. The CSS rule for mobile did not get updated at the time, so updating it now.

Simplify CSS parser to check themes

fb42dae

Update theme check tests

0b037c1

Add check for missing CSS variables

e7d8ad6

Remove duplicate warnings

a528f68

Revert "Rollup merge of rust-lang#101496 - spastorino:lower_lifetime_…

669f2d4

…binder_api_changes, r=oli-obk" This reverts commit 953a6b3, reversing changes made to b5ffbd3.

Pass ImplTraitContext as &, there's no need for that to be &mut

8610550

Get rid of 'b lifetime in lower_param_bounds_mut

45d8049

fix rust-lang#101797: Suggest associated const for incorrect use of l…

98e20c0

…et in traits

Correctly handle parens

d3529ce

slight vertical formatting

6d7beaf

tweak suggestion

4bf7d2c

rustdoc: use more precise URLs for jump-to-definition links

ef24747

As an example, this cuts down <https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_middle/ty/mod.rs.html> by about 11%. $ du -h new_mod.rs.html old_mod.rs.html 296K new_mod.rs.html 332K old_mod.rs.html

rustdoc: fix test cases

669498c

rustdoc: remove no-op CSS .block { padding: 0 }

7c8e4ef

This rule was changed in 8fb1250 from the original version that had a non-zero padding. It's not needed, because it's not overriding anything that would've given `.block` a padding.

Rollup merge of rust-lang#101825 - spastorino:fix-rpit-changes, r=oli…

8ba133f

…-obk Fix back RPIT changes r? `@oli-obk` cc `@compiler-errors`

Rollup merge of rust-lang#101843 - chenyukang:fix-101797, r=oli-obk

72d9e08

Suggest associated const for incorrect use of let in traits Fixes rust-lang#101797

Rollup merge of rust-lang#101859 - Rageking8:slight-vertical-formatti…

9a72ded

…ng, r=compiler-errors Slight vertical formatting

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Sep 16, 2022

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 16, 2022

bors mentioned this pull request Sep 16, 2022

Partially revert #101433 #101902

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 16, 2022

bors merged commit 54f20bb into rust-lang:master Sep 16, 2022

rustbot added this to the 1.65.0 milestone Sep 16, 2022

bors mentioned this pull request Sep 16, 2022

rustdoc: add hash to filename of toolchain files #101702

Merged

GuillaumeGomez deleted the rollup-ured85q branch September 16, 2022 17:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 7 pull requests #101895

Rollup of 7 pull requests #101895

GuillaumeGomez commented Sep 16, 2022

GuillaumeGomez commented Sep 16, 2022

bors commented Sep 16, 2022

bors commented Sep 16, 2022

bors commented Sep 16, 2022

rust-timer commented Sep 16, 2022

rust-timer commented Sep 16, 2022

Rollup of 7 pull requests #101895

Rollup of 7 pull requests #101895

Conversation

GuillaumeGomez commented Sep 16, 2022

GuillaumeGomez commented Sep 16, 2022

bors commented Sep 16, 2022

bors commented Sep 16, 2022

bors commented Sep 16, 2022

rust-timer commented Sep 16, 2022

rust-timer commented Sep 16, 2022

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Footnotes