-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[crater experiment] Turn on debug assertions #101929
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
@bors try |
⌛ Trying commit ca14fbe with merge 3bbb5242a8064de4ca3af4036745ddf603ddaa85... |
☀️ Try build successful - checks-actions |
@craterbot run mode=build-only |
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🎉 Experiment
|
Looks like the majority of these are SIGILL crashes in either It looks like the rest of the regressions are OOMs of some kind or another. I reported what looks like the single net-new finding here: #102074 There are also plenty of other ICEs in here, but nothing new as best I can tell. I think this matter is closed. |
The standard library has a lot more debug assertions since #92686 which also found and fixed some UB in the compiler using them. It has been suggested that as a follow-up to trying out the LLVM assertions in #101591, we try out the Rust assertions.
I think this would only need a check run.