-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add better assert messages for f32/f64 clamps #101959
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
874eb5d
to
cbb153a
Compare
This comment has been minimized.
This comment has been minimized.
cbb153a
to
318c7f2
Compare
Minor tweak to the message, but otherwise LGTM. r=me with the suggestions (or similar) applied. |
318c7f2
to
c7f54da
Compare
Does this work? |
@Xaeroxe: 🔑 Insufficient privileges: Not in reviewers |
I'd like this to go into the 1.66 release. With the inclusion of the new clippy lint |
@joshtriplett this is ready for re-review |
Thank you! |
lgtm, thanks! @bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (3e565f1): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
No description provided.