rustdoc: remove unnecessary max-width on headers
#102066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @CraftSpider (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Sep 20, 2022
|
Thanks! r=me once CI pass. |
|
@bors r=GuillaumeGomez rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 21, 2022
…dth, r=GuillaumeGomez rustdoc: remove unnecessary `max-width` on headers This code was added in 003b2bc to prevent these headers from overlapping `.out-of-band` side items. That stopped being a problem when 3f92ff3 switched rustdoc over to using `float`, rather than `position: absolute`, to implement this.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Sep 21, 2022
…dth, r=GuillaumeGomez rustdoc: remove unnecessary `max-width` on headers This code was added in 003b2bc to prevent these headers from overlapping `.out-of-band` side items. That stopped being a problem when 3f92ff3 switched rustdoc over to using `float`, rather than `position: absolute`, to implement this.
|
(Sorry, misclicked the close button!) Seems failed in rollup: https://github.com/rust-lang/rust/actions/runs/3098005981/jobs/5015365954 |
bors
added
S-waiting-on-author
|
It looks like this PR had an implicit merge conflict with #102008. I've rebased it and made a change to the notable-trait.goml test. @GuillaumeGomez does the change in f528d49 look right to you? |
notriddle
force-pushed
the
notriddle/headers-max-width
branch
from
d355b0e
to
f528d49
Compare
notriddle
added
S-waiting-on-review
GuillaumeGomez
approved these changes
Sep 22, 2022
|
It was a pretty bad matchup indeed. Thanks for the fix! Removing the right margin on mobile definitely make sense. @bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 22, 2022
…dth, r=GuillaumeGomez rustdoc: remove unnecessary `max-width` on headers This code was added in 003b2bc to prevent these headers from overlapping `.out-of-band` side items. That stopped being a problem when 3f92ff3 switched rustdoc over to using `float`, rather than `position: absolute`, to implement this.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 22, 2022
…dth, r=GuillaumeGomez rustdoc: remove unnecessary `max-width` on headers This code was added in 003b2bc to prevent these headers from overlapping `.out-of-band` side items. That stopped being a problem when 3f92ff3 switched rustdoc over to using `float`, rather than `position: absolute`, to implement this.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 23, 2022
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#100734 (Split out async_fn_in_trait into a separate feature) - rust-lang#101664 (Note if mismatched types have a similar name) - rust-lang#101815 (Migrated the rustc_passes annotation without effect diagnostic infrastructure) - rust-lang#102042 (Distribute rust-docs-json via rustup.) - rust-lang#102066 (rustdoc: remove unnecessary `max-width` on headers) - rust-lang#102095 (Deduplicate two functions that would soon have been three) - rust-lang#102104 (Set 'exec-env:RUST_BACKTRACE=0' in const-eval-select tests) - rust-lang#102112 (Allow full relro on powerpc64-unknown-linux-gnu) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was added in 003b2bc to prevent these headers from overlapping
.out-of-bandside items. That stopped being a problem when 3f92ff3 switched rustdoc over to usingfloat, rather thanposition: absolute, to implement this.