Skip to content

Add missing documentation for bool::from_str #102094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2022
Merged

Add missing documentation for bool::from_str #102094

merged 1 commit into from
Sep 23, 2022

Conversation

@GuillaumeGomez
Copy link
Member

Fixes #101870.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 21, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 21, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Contributor

r? @scottmcm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 21, 2022
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 21, 2022
Closed
@GuillaumeGomez
Copy link
Member Author

r? @thomcc

@rust-highfive rust-highfive assigned thomcc and unassigned scottmcm Sep 22, 2022
@scottmcm
Copy link
Member

Thanks! This looks like a good clarification to me.

@bors r+ rollup

This is de-facto true, and we generally can't change FromStrs, so I don't think this needs an FCP, but FYI just in case @rust-lang/libs-api : this documents that parsing a bool only accepts "true" and "false" (and thus not "yes" or "0" or ...).

@bors
Copy link
Collaborator

bors commented Sep 23, 2022

📌 Commit b4fdc58 has been approved by scottmcm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 23, 2022
@matthiaskrgr
Rollup merge of rust-lang#102094 - GuillaumeGomez:bool-from-str-missi…
eb8d03c 
…ng-docs, r=scottmcm

Add missing documentation for `bool::from_str`

Fixes rust-lang#101870.
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 23, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 23, 2022
@matthiaskrgr
Rollup merge of rust-lang#102094 - GuillaumeGomez:bool-from-str-missi…
8becf0a 
…ng-docs, r=scottmcm

Add missing documentation for `bool::from_str`

Fixes rust-lang#101870.
This was referenced Sep 23, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 23, 2022
@bors
Auto merge of rust-lang#102192 - matthiaskrgr:rollup-0ctjzco, r=matth…
4a14677 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#102094 (Add missing documentation for `bool::from_str`)
 - rust-lang#102115 (Add examples to `bool::then` and `bool::then_some`)
 - rust-lang#102134 (Detect panic strategy using `rustc --print cfg`)
 - rust-lang#102137 (Don't convert valtree to constvalue during normalization)
 - rust-lang#102148 (add regression test for miri issue 2433)
 - rust-lang#102158 (rustdoc: clean up CSS/DOM for deprecation warnings)
 - rust-lang#102177 (Fix a typo in `std`'s root docs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 986fc4b into rust-lang:master Sep 23, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 23, 2022
@GuillaumeGomez GuillaumeGomez deleted the bool-from-str-missing-docs branch September 23, 2022 22:35
oli-obk pushed a commit to oli-obk/rust that referenced this pull request Sep 28, 2022
@bors
Auto merge of rust-lang#102192 - matthiaskrgr:rollup-0ctjzco, r=matth…
1da69f2 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#102094 (Add missing documentation for `bool::from_str`)
 - rust-lang#102115 (Add examples to `bool::then` and `bool::then_some`)
 - rust-lang#102134 (Detect panic strategy using `rustc --print cfg`)
 - rust-lang#102137 (Don't convert valtree to constvalue during normalization)
 - rust-lang#102148 (add regression test for miri issue 2433)
 - rust-lang#102158 (rustdoc: clean up CSS/DOM for deprecation warnings)
 - rust-lang#102177 (Fix a typo in `std`'s root docs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#102192 - matthiaskrgr:rollup-0ctjzco, r=matth…
6e81886 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#102094 (Add missing documentation for `bool::from_str`)
 - rust-lang#102115 (Add examples to `bool::then` and `bool::then_some`)
 - rust-lang#102134 (Detect panic strategy using `rustc --print cfg`)
 - rust-lang#102137 (Don't convert valtree to constvalue during normalization)
 - rust-lang#102148 (add regression test for miri issue 2433)
 - rust-lang#102158 (rustdoc: clean up CSS/DOM for deprecation warnings)
 - rust-lang#102177 (Fix a typo in `std`'s root docs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@thomcc thomcc

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.66.0

Development

Successfully merging this pull request may close these issues.

"TRUE" does not parse into boolean

6 participants

@GuillaumeGomez @rustbot @rust-highfive @scottmcm @bors @thomcc