- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
Add missing space between notable trait tooltip and where clause #102107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            bors
  merged 1 commit into
  rust-lang:master
from
Urgau:rustdoc-missing-space-before-where-clause
  
      
      
   
  Sep 22, 2022 
      
    
                
     Merged
            
            Add missing space between notable trait tooltip and where clause #102107
                    bors
  merged 1 commit into
  rust-lang:master
from
Urgau:rustdoc-missing-space-before-where-clause
  
      
      
   
  Sep 22, 2022 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    GuillaumeGomez
  
              
              approved these changes
              
                  
                    Sep 22, 2022 
                  
              
              
            
            
| Thanks! @bors r+ rollup | 
    
  bors 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Sep 22, 2022 
    
    
      
  
    
      
    
  
Rollup of 8 pull requests Successful merges: - rust-lang#101598 (Update rustc's information on Android's sanitizers) - rust-lang#102036 (Remove use of `io::ErrorKind::Other` in std) - rust-lang#102037 (Make cycle errors recoverable) - rust-lang#102069 (Skip `Equate` relation in `handle_opaque_type`) - rust-lang#102076 (rustc_transmute: fix big-endian discriminants) - rust-lang#102107 (Add missing space between notable trait tooltip and where clause) - rust-lang#102119 (Fix a typo “pararmeter” in error message) - rust-lang#102131 (Added which number is computed in compute_float.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
| The bug is also present in beta, nominating for beta backport. | 
| Beta backport accepted, rather innocuous but welcome fix to backport @rustbot label +beta-accepted | 
      
     Merged
  
    
  bors 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Oct 21, 2022 
    
    
      
  
    
      
    
  
[beta] backports - Use rebind instead of dummy binder in `SameTypeModuloInfer` relation rust-lang#102059 - Add missing space between notable trait tooltip and where clause rust-lang#102107 - Avoid repeated re-initialization of the BufReader buffer rust-lang#102760 - Ensure enum cast moves rust-lang#103016 - Fix `TyKind::is_simple_path` rust-lang#103176 - Do anonymous lifetimes remapping correctly for nested rpits rust-lang#103205 - [beta] Cargo backport 1.65.0 rust-lang#103303 - linker: Fix weak lang item linking with combination windows-gnu + LLD + LTO rust-lang#103092 r? `@ghost`
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    beta-accepted
  Accepted for backporting to the compiler in the beta channel. 
  
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  
    T-rustdoc
  Relevant to the rustdoc team, which will review and decide on the PR/issue. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This PR add a missing space between the notable trait tooltip and the where clause.
The issue can be seeing on the BufRead page.
Added a simple snapshot regression test in
src/test/rustdoc/where.rs.Before:

After:

r? @GuillaumeGomez