Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve: Set effective visibilities for imports more precisely #102109

Merged
merged 2 commits into from
Sep 24, 2022
Merged

resolve: Set effective visibilities for imports more precisely #102109

merged 2 commits into from
Sep 24, 2022

Conversation

petrochenkov
Copy link
Contributor

Instead of setting them for all primary and additional IDs of the import, only set them for the binding's true ID.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 21, 2022
@rust-highfive
Copy link
Contributor

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 21, 2022
@petrochenkov
Copy link
Contributor Author

cc @Bryanskiy

@oli-obk
Copy link
Contributor

oli-obk commented Sep 22, 2022

Does this have any user visible effects?

@petrochenkov
Copy link
Contributor Author

I'll try to construct a test.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2022
@petrochenkov
effective visibility: Add test for a reexport of two names
5be901a 
in different namespaces, one public and another private.
@petrochenkov
resolve: Set effective visibilities for imports more precisely
4ddff03 
Instead of setting them for all primary and additional IDs of the import, only set them for the binding's true ID.
@petrochenkov
Copy link
Contributor Author

Updated with a test.
@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 22, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Sep 22, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 22, 2022

📌 Commit 4ddff03 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 24, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 24, 2022
@bors
Auto merge of rust-lang#102234 - matthiaskrgr:rollup-5cb20l1, r=matth…
6580010 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#100823 (Refactor some `std` code that works with pointer offstes)
 - rust-lang#102088 (Fix wrongly refactored Lift impl)
 - rust-lang#102109 (resolve: Set effective visibilities for imports more precisely)
 - rust-lang#102186 (Add const_closure, Constify Try trait)
 - rust-lang#102203 (rustdoc: remove no-op CSS `#source-sidebar { z-index }`)
 - rust-lang#102204 (Make `ManuallyDrop` satisfy `~const Destruct`)
 - rust-lang#102210 (diagnostics: avoid syntactically invalid suggestion in if conditionals)
 - rust-lang#102226 (bootstrap/miri: switch to non-deprecated env var for setting the sysroot folder)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit eb628e8 into rust-lang:master Sep 24, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 24, 2022
@djc djc mentioned this pull request Sep 27, 2022
Closed
oli-obk added a commit to oli-obk/rust that referenced this pull request Oct 19, 2022
@oli-obk
Revert "Rollup merge of rust-lang#102109 - petrochenkov:addids, r=oli…
471e0a1 
…-obk"

This reverts commit eb628e8, reversing
changes made to bf167e0.
@petrochenkov petrochenkov mentioned this pull request Nov 5, 2022
Merged
@petrochenkov petrochenkov deleted the addids branch February 22, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
5 participants
@petrochenkov @rust-highfive @oli-obk @bors @rustbot