Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include lint errors in error count for -Ztreat-err-as-bug #102249

Closed
wants to merge 1 commit into from

Conversation

Blutornato
Copy link

I wanna contact you in personal is it posible

This was a regression from rust-lang#87337;
the `panic_if_treat_err_as_bug` function only checked the number of hard
errors, not the number of lint errors.
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 24, 2022
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @davidtwco (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 24, 2022
@davidtwco
Copy link
Member

@jyn514 do you have any context for this change?

@jyn514
Copy link
Member

jyn514 commented Sep 26, 2022

@davidtwco this looks like a duplicate of my earlier PR: #91425
I checked and none of those changes have been reverted on master

fn panic_if_treat_err_as_bug(&self) {
if self.treat_err_as_bug() {
match (
self.err_count() + self.lint_err_count,
self.flags.treat_err_as_bug.map(|c| c.get()).unwrap_or(0),
) {
, so this only shows a diff because the branch point is very out of date.

@jyn514
Copy link
Member

jyn514 commented Sep 26, 2022

Oh, this is from my fork for some reason. No, I have no idea what's going on here.

@jyn514 jyn514 closed this Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants