Rustdoc: Properly strip private modules #10233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A private module will survive the strip-private pass if it contains trait implementations, which aren't stripped until a separate pass in render.
bors
added a commit
that referenced
this pull request
Nov 2, 2013
A private module will survive the strip-private pass if it contains trait implementations, which aren't stripped until a separate pass in render.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 10, 2023
Migrate `write.rs` to `rustc_ast::FormatArgs` changelog: none Part 1 of rust-lang#10233 The additions to `clippy_utils` are the main novelty of this PR, there's no removals yet since other parts still rely on `FormatArgsExpn` The changes to `write.rs` itself are relatively straightforward this time around, as there's no lints in it that rely on type checking format params r? `@flip1995`
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 6, 2023
…earth Replace remaining usage of `FormatArgsExpn` Closes rust-lang#10233 Removes `FormatArgsExpn` & friends now that they're unused changelog: none r? `@Manishearth`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A private module will survive the strip-private pass if it contains
trait implementations, which aren't stripped until a separate pass in
render.