Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak FulfillProcessor. #102348

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Tweak FulfillProcessor. #102348

merged 1 commit into from
Sep 28, 2022

Conversation

nnethercote
Copy link
Contributor

Avoids some unnecessary references and lifetimes.

r? @jackh726

@nnethercote
Tweak FulfillProcessor.
b69c335 
Avoids some unnecessary references and lifetimes.
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 27, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 27, 2022
@nnethercote
Copy link
Contributor Author

This code is very perf-sensitive, let's see what happens on CI.

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 27, 2022
@bors
Copy link
Contributor

bors commented Sep 27, 2022

⌛ Trying commit b69c335 with merge a4cc62f53b515993f1762962de2fa4015d8268b0...

@bors
Copy link
Contributor

bors commented Sep 27, 2022

☀️ Try build successful - checks-actions
Build commit: a4cc62f53b515993f1762962de2fa4015d8268b0 (a4cc62f53b515993f1762962de2fa4015d8268b0)

@rust-timer
Copy link
Collaborator

Queued a4cc62f53b515993f1762962de2fa4015d8268b0 with parent cd4d9d9, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a4cc62f53b515993f1762962de2fa4015d8268b0): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.7% [0.6%, 0.8%] 6
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 9.0% [9.0%, 9.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 2.0% [2.0%, 2.0%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.0% [-3.0%, -3.0%] 1
All ❌✅ (primary) 2.0% [2.0%, 2.0%] 1

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 27, 2022
@nnethercote
Copy link
Contributor Author

keccak has been noisy lately, let's try again.

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 27, 2022
@bors
Copy link
Contributor

bors commented Sep 27, 2022

⌛ Trying commit b69c335 with merge 3a4ce96627f30d463bd767ef384a2a14135bbd6f...

@jackh726
Copy link
Member

r=me when you're happy with perf

@bors
Copy link
Contributor

bors commented Sep 28, 2022

☀️ Try build successful - checks-actions
Build commit: 3a4ce96627f30d463bd767ef384a2a14135bbd6f (3a4ce96627f30d463bd767ef384a2a14135bbd6f)

@rust-timer
Copy link
Collaborator

Queued 3a4ce96627f30d463bd767ef384a2a14135bbd6f with parent 470e518, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3a4ce96627f30d463bd767ef384a2a14135bbd6f): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.9% [-1.0%, -0.9%] 2
Improvements ✅
(secondary)		 -2.0% [-2.3%, -1.8%] 6
All ❌✅ (primary) -0.9% [-1.0%, -0.9%] 2

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.5% [-3.7%, -3.4%] 2
All ❌✅ (primary) - - 0

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 28, 2022
@nnethercote
Copy link
Contributor Author

keccak improved in one, regressed in the other, I think this is just noise.

@bors r=jackh726 rollup=always

@bors
Copy link
Contributor

bors commented Sep 28, 2022

📌 Commit b69c335 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2022
@JohnTitor JohnTitor mentioned this pull request Sep 28, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 28, 2022
@bors
Auto merge of rust-lang#102388 - JohnTitor:rollup-mbyw6fl, r=JohnTitor
837bf37 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#100747 (Add long description and test for E0311)
 - rust-lang#102232 (Stabilize bench_black_box)
 - rust-lang#102288 (Suggest unwrapping `???<T>` if a method cannot be found on it but is present on `T`.)
 - rust-lang#102338 (Deny associated type bindings within associated type bindings)
 - rust-lang#102347 (Unescaping cleanups)
 - rust-lang#102348 (Tweak `FulfillProcessor`.)
 - rust-lang#102378 (Use already resolved `self_ty` in `confirm_fn_pointer_candidate`)
 - rust-lang#102380 (rustdoc: remove redundant mobile `.source > .sidebar` CSS)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bf54cfe into rust-lang:master Sep 28, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 28, 2022
@nnethercote nnethercote deleted the tweak-FulfillProcessor branch September 28, 2022 20:54
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@JohnTitor
Rollup merge of rust-lang#102348 - nnethercote:tweak-FulfillProcessor…
28b3615 
…, r=jackh726

Tweak `FulfillProcessor`.

Avoids some unnecessary references and lifetimes.

r? `@jackh726`
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#102388 - JohnTitor:rollup-mbyw6fl, r=JohnTitor
cf62e8a 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#100747 (Add long description and test for E0311)
 - rust-lang#102232 (Stabilize bench_black_box)
 - rust-lang#102288 (Suggest unwrapping `???<T>` if a method cannot be found on it but is present on `T`.)
 - rust-lang#102338 (Deny associated type bindings within associated type bindings)
 - rust-lang#102347 (Unescaping cleanups)
 - rust-lang#102348 (Tweak `FulfillProcessor`.)
 - rust-lang#102378 (Use already resolved `self_ty` in `confirm_fn_pointer_candidate`)
 - rust-lang#102380 (rustdoc: remove redundant mobile `.source > .sidebar` CSS)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jackh726 jackh726

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
6 participants
@nnethercote @rust-timer @bors @jackh726 @rust-highfive @rustbot