Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: remove no-op CSS h3.variant, .sub-variant h4 { border-bottom: none } #102505

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

notriddle
Copy link
Contributor

This rule, added in 69df43b to override the default h4 style, has been obsoleted when a65c98f changed it so that only the top docblock put border-bottom on h4.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jsha (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Sep 30, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 30, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 30, 2022
@notriddle notriddle changed the title rustdoc: remove no-op CSS .sub-variant h4 { border-bottom: none } rustdoc: remove no-op CSS h3.variant, .sub-variant h4 { border-bottom: none } Sep 30, 2022
…m: none }`

This rule, added in 69df43b to override the
default `h4` style, has been obsoleted when
a65c98f changed it so that only the top
docblock put `border-bottom` on `h4.`
@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 30, 2022

📌 Commit 19b297c has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 30, 2022
…umeGomez

rustdoc: remove no-op CSS `h3.variant, .sub-variant h4 { border-bottom: none }`

This rule, added in 69df43b to override the default `h4` style, has been obsoleted when a65c98f changed it so that only the top docblock put `border-bottom` on `h4.`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 30, 2022
…umeGomez

rustdoc: remove no-op CSS `h3.variant, .sub-variant h4 { border-bottom: none }`

This rule, added in 69df43b to override the default `h4` style, has been obsoleted when a65c98f changed it so that only the top docblock put `border-bottom` on `h4.`
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 30, 2022
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#102276 (Added more const_closure functionality)
 - rust-lang#102382 (Manually order `DefId` on 64-bit big-endian)
 - rust-lang#102421 (remove the unused :: between trait and type to give user correct diag…)
 - rust-lang#102495 (Reinstate `hir-stats.rs` test for stage 1.)
 - rust-lang#102505 (rustdoc: remove no-op CSS `h3.variant, .sub-variant h4 { border-bottom: none }`)
 - rust-lang#102506 (Specify `DynKind::Dyn`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5dd4584 into rust-lang:master Sep 30, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 30, 2022
@notriddle notriddle deleted the sub-variant-h4 branch September 30, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants