Rollup of 7 pull requests #102526
Merged
Rollup of 7 pull requests #102526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes rust-lang#102156.
Sometimes it can happen that invalid code like a TyKind::Error makes its way through the compiler without triggering any errors (this is always a bug in rustc but bugs do happen sometimes :)). These ICEs will manifest in the backend like as cg_llvm not being able to get the layout of `[type error]`, which makes it hard to debug. By flushing before codegen, we display all the delayed bugs, making it easier to trace it to the root of the problem.
Fixes another regression caused by 8846c08, this time fixing the appearance of methods that have no docblock (we didn't notice this one because libstd docs *always* have docblocks). See how it looks without the fix at https://doc.rust-lang.org/nightly/nightly-rustc/rustdoc/clean/types/enum.Type.html#implementations
Fixes another regression caused by 8846c08, this time fixing the appearance of methods that have no docblock (we didn't notice this one because libstd docs *always* have docblocks). See how it looks at https://doc.rust-lang.org/nightly/nightly-rustc/rustdoc/clean/types/trait.AttributesExt.html
Also add a few more assertions for some relevant token-related types. And fix an erroneous comment in `rustc_errors`.
Fix ICE in const_trait check code This fixes rust-lang#102156.
…nch-error, r=cjgillot Flush delayed bugs before codegen Sometimes it can happen that invalid code like a TyKind::Error makes its way through the compiler without triggering any errors (this is always a bug in rustc but bugs do happen sometimes :)). These ICEs will manifest in the backend like as cg_llvm not being able to get the layout of `[type error]`, which makes it hard to debug. By flushing before codegen, we display all the delayed bugs, making it easier to trace it to the root of the problem. I tried this on rust-lang#102366 and it showed tons of of delayed bugs and no error in cg_llvm, so it seems to be working.
…, r=cjgillot create def ids for impl traits during ast lowering r? `@cjgillot`
…lifetime, r=cjgillot Generate synthetic region from `impl` even in closure body within an associated fn Fixes rust-lang#102209
…c-bindings, r=cjgillot Don't lower assoc bindings just to deny them Some clean-up: rust-lang#102338 (comment)
…s-some-more, r=lqd Group together more size assertions. Also add a few more assertions for some relevant token-related types. And fix an erroneous comment in `rustc_errors`. r? `@lqd`
…tion, r=GuillaumeGomez rustdoc: add missing margin to no-docblock methods Fixes another regression caused by 8846c08, this time fixing the appearance of methods that have no docblock (we didn't notice this one because libstd docs *always* have docblocks). See how it looks at https://doc.rust-lang.org/nightly/nightly-rustc/rustdoc/clean/types/enum.Type.html#implementations <details> # Before  # After  </details> See how it looks at https://doc.rust-lang.org/nightly/nightly-rustc/rustdoc/clean/types/trait.AttributesExt.html <details> # Before  # After  </details>
rustbot
added
A-query-system
|
@bors r+ rollup=never p=7 |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 2fadfe0 with merge cb13f9b94cc2d24b29f72e50bedc1acd5fbf1384... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
@bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: c5b105dc9a In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Oct 1, 2022
|
Finished benchmarking commit (de341fe): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
impleven in closure body within an associated fn #102490 (Generate synthetic region fromimpleven in closure body within an associated fn)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup