Migrate CSS theme for search results #102547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
the
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha A change occurred in the Ayu theme. cc @Cldfire |
rust-highfive
added
the
S-waiting-on-review
notriddle
approved these changes
Oct 1, 2022
|
One thing I notice here: in the light theme, the _foreground_ color for
links focused with the keyboard becomes black. For hovered links, it stays
the underlying color (depending on the type). I think both focus and hover
should have the same behavior: keep the underlying color.
This is already-existing behavior, but it became more noticeable once the
changing background color for focused links went away (which is a good
change!).
… Message ID: ***@***.***>
|
|
Indeed, good catch! I'll update it in the next days. |
GuillaumeGomez
force-pushed
the
migrate-css-theme-search-result
branch
from
f52eaaa to
9ca79e2
Compare
|
I updated the CSS to unify hover and focus and updated the online demo. |
GuillaumeGomez
changed the title
|
☔ The latest upstream changes (presumably #102627) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez
force-pushed
the
migrate-css-theme-search-result
branch
from
9ca79e2 to
b8a63a6
Compare
|
Fixed the conflict. |
|
@bors r=notriddle,jsha rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 4, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#102441 (Suggest unwrap_or_else when a closure is given) - rust-lang#102547 (Migrate CSS theme for search results) - rust-lang#102567 (Delay evaluating lint primary message until after it would be suppressed) - rust-lang#102624 (rustdoc: remove font family CSS on `.rustdoc-toggle summary::before`) - rust-lang#102628 (Change the parameter name of From::from to `value`) - rust-lang#102637 (Ignore fuchsia on two compiler tests) - rust-lang#102639 (Improve spans when splitting multi-char operator tokens for proc macros.) Failed merges: - rust-lang#102496 (Suggest `.into()` when all other coercion suggestions fail) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #98460.
Just like #102237, I unified theme to how the
ayuhandles this one: only one color for the background when search results are focused or hovered.You can test it here.
cc @jsha
r? @notriddle
PS: The repetition in GUI tests is getting out of hand so I opened GuillaumeGomez/browser-UI-test#363 to think about adding possibility to declare functions so we can greatly improve this.