rustdoc: remove no-op CSS on .impl, .method etc
#102550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `.impl-items { flex-basis: 100% }` and `h3.impl, h3.method, h4.method,
h3.type, h4.type, h4.associatedconstant` were added in
34bd2b8, it seems like it was a mistake even
then. According to MDN, [flex-basis] does nothing unless the box it's applied
to is a flex *item*, a child of a flex container. However, when this was
added, these elements were flex containers themselves.
[flex-basis]: https://developer.mozilla.org/en-US/docs/Web/CSS/flex-basis
This property was added to help with positioning the `[+]/[-]` toggle. It is no longer necessary, because `details.rustdoc-toggle` already has `position:relative` set on it.
rustbot
added
the
T-rustdoc
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jsha (or someone else) soon. Please see the contribution instructions for more information. |
Collaborator
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Oct 2, 2022
Member
|
Thanks! @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 3, 2022
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#102550 (rustdoc: remove no-op CSS on `.impl, .method` etc) - rust-lang#102591 (Fix duplicate usage of `a` article.) - rust-lang#102592 (Remove a couple lifetimes that can be infered) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: http://notriddle.com/notriddle-rustdoc-demos/impl/index.html
flex-basis: 100%When
.impl-items { flex-basis: 100% }andh3.impl, h3.method, h4.method, h3.type, h4.type, h4.associatedconstantwere added in 34bd2b8, it seems like it was a mistake even then. According to MDN, flex-basis does nothing unless the box it's applied to is a flex item, a child of a flex container. However, when this was added, these elements were flex containers themselves.position: relativeThis property was added to help with positioning the
[+]/[-]toggle. It is no longer necessary, becausedetails.rustdoc-togglealready hasposition:relativeset on it.