Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make feature(const_btree_len) implied by feature(const_btree_new) #102556

Merged
merged 2 commits into from
Oct 2, 2022
Merged

Make feature(const_btree_len) implied by feature(const_btree_new) #102556

merged 2 commits into from
Oct 2, 2022

Conversation

WaffleLapkin
Copy link
Member

...this should fix code that used the old feature that was changed in #102197

cc @davidtwco it seems like tidy doesn't check implied_by, should it?

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 1, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 1, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 1, 2022
@WaffleLapkin
Copy link
Member Author

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 1, 2022
@Mark-Simulacrum
Copy link
Member

Yes, tidy probably ought to check implied_by (presuming there's room to check something).

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 2, 2022

📌 Commit da78c1f has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 2, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 2, 2022
@Dylan-DPC
Rollup merge of rust-lang#102556 - WaffleLapkin:implied_by_btree_new,…
34c7111 
… r=Mark-Simulacrum

Make `feature(const_btree_len)` implied by `feature(const_btree_new)`

...this should fix code that used the old feature that was changed in rust-lang#102197

cc `@davidtwco` it seems like tidy doesn't check `implied_by`, should it?
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 2, 2022
@Dylan-DPC
Rollup merge of rust-lang#102556 - WaffleLapkin:implied_by_btree_new,…
a260d63 
… r=Mark-Simulacrum

Make `feature(const_btree_len)` implied by `feature(const_btree_new)`

...this should fix code that used the old feature that was changed in rust-lang#102197

cc ``@davidtwco`` it seems like tidy doesn't check `implied_by`, should it?
This was referenced Oct 2, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 2, 2022
@bors
Auto merge of rust-lang#102586 - Dylan-DPC:rollup-g107h6z, r=Dylan-DPC
39323a5 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#100451 (Do not panic when a test function returns Result::Err.)
 - rust-lang#102098 (Use fetch_update in sync::Weak::upgrade)
 - rust-lang#102538 (Give `def_span` the same SyntaxContext as `span_with_body`.)
 - rust-lang#102556 (Make `feature(const_btree_len)` implied by `feature(const_btree_new)`)
 - rust-lang#102566 (Add a known-bug test for rust-lang#102498)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 890a327 into rust-lang:master Oct 2, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 2, 2022
@WaffleLapkin WaffleLapkin deleted the implied_by_btree_new branch October 2, 2022 18:56
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@Dylan-DPC
Rollup merge of rust-lang#102556 - WaffleLapkin:implied_by_btree_new,…
9b517a4 
… r=Mark-Simulacrum

Make `feature(const_btree_len)` implied by `feature(const_btree_new)`

...this should fix code that used the old feature that was changed in rust-lang#102197

cc ```@davidtwco``` it seems like tidy doesn't check `implied_by`, should it?
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#102586 - Dylan-DPC:rollup-g107h6z, r=Dylan-DPC
cdc743a 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#100451 (Do not panic when a test function returns Result::Err.)
 - rust-lang#102098 (Use fetch_update in sync::Weak::upgrade)
 - rust-lang#102538 (Give `def_span` the same SyntaxContext as `span_with_body`.)
 - rust-lang#102556 (Make `feature(const_btree_len)` implied by `feature(const_btree_new)`)
 - rust-lang#102566 (Add a known-bug test for rust-lang#102498)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@steffahn steffahn mentioned this pull request Feb 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
5 participants
@WaffleLapkin @rustbot @rust-highfive @Mark-Simulacrum @bors