Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve instance: missing value to delay_span_bug #102653

Merged
merged 1 commit into from
Oct 4, 2022
Merged

resolve instance: missing value to delay_span_bug #102653

merged 1 commit into from
Oct 4, 2022

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Oct 4, 2022

No description provided.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 4, 2022
@rust-highfive
Copy link
Collaborator

r? @fee1-dead

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 4, 2022
@fee1-dead
Copy link
Member

I think it is okay to turn this into a logical error, but we might need a comment distinguishing when this returns Ok(None) and when this returns Err(ErrorGuaranteed). Perhaps a comment to document this?

After that r=me.

@fee1-dead fee1-dead added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2022
@lcnr
Copy link
Contributor Author

lcnr commented Oct 4, 2022

@bors r=fee1-dead rollup

@bors
Copy link
Contributor

bors commented Oct 4, 2022

📌 Commit 93a17c8 has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 4, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 4, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 4, 2022
@bors
Auto merge of rust-lang#102666 - matthiaskrgr:rollup-tuge18t, r=matth…
01af504 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#102241 (Package `rust-docs-json` into nightly components (take 3))
 - rust-lang#102488 (Check generic argument compatibility when projecting assoc ty)
 - rust-lang#102647 (Only allow ~const bounds for traits with #[const_trait])
 - rust-lang#102648 (Add test for rust-lang#102605)
 - rust-lang#102651 (It's not about types or consts, but the lack of regions)
 - rust-lang#102653 (resolve instance: missing value to `delay_span_bug`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@compiler-errors
Copy link
Member

@lcnr does this fix a bug, or just being defensive against future bugs?

@bors bors merged commit db94aed into rust-lang:master Oct 4, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 4, 2022
@lcnr
Copy link
Contributor Author

lcnr commented Oct 28, 2022

@lcnr does this fix a bug, or just being defensive against future bugs?

purely being defensive, though I vaguely remember that changing this in a wip PR removed some incorrect error messages 🤷

@lcnr lcnr deleted the delay_span_bug branch October 28, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fee1-dead fee1-dead

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lcnr @rust-highfive @fee1-dead @bors @compiler-errors @rustbot