Skip to content

Conversation

zertosh
Copy link
Contributor

@zertosh zertosh commented Oct 9, 2022

This update removes the only .gitignore found in rustc-src:

vendor/syn/tests/.gitignore
vendor/syn-1.0.91/tests/.gitignore
vendor/syn-1.0.95/tests/.gitignore

To check-in rustc-src for hermetic builds in environments with
restrictive .gitignore policies, one has to remove these
tests/.gitignore and patch the respective
.cargo-checksum.json.syn >1.0.101 includes dtolnay/syn@3c49303bed7a,
which removes its tests/.gitignore. Now the syn crates.io package
has no .gitignore.

rustc-src's vendor is produced from the root Cargo.toml,
src/tools/rust-analyzer/Cargo.toml,
compiler/rustc_codegen_cranelift/Cargo.toml, and
src/bootstrap/Cargo.toml. rustc_codegen_cranelift does not use
syn.

This was produced with:

cargo update --package syn --precise 1.0.102 \

cargo update --package syn --precise 1.0.102 \
    --manifest-path src/tools/rust-analyzer/Cargo.toml

cargo update --package syn --precise 1.0.102 \
    --manifest-path src/bootstrap/Cargo.toml

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Oct 9, 2022
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2022
@zertosh
Copy link
Contributor Author

zertosh commented Oct 9, 2022

r? @dtolnay

@rust-log-analyzer

This comment has been minimized.

@zertosh
Copy link
Contributor Author

zertosh commented Oct 9, 2022

I can update src/tools/tidy/src/deps.rs to add unicode-ident to PERMITTED_RUSTC_DEPENDENCIES, but what about the licensing? Permit (MIT OR Apache-2.0) AND Unicode-DFS-2016 or add unicode-indent as an exception?

Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Libcore, and unicode-xid which rustc depends on, both already use the same Unicode tables as unicode-ident, so they already require compliance with Unicode-DFS-2016 despite not stating such in their license metadata in Cargo.toml. Please add Unicode-DFS-2016 as a permitted license.

@zertosh zertosh requested a review from dtolnay October 9, 2022 17:53
@dtolnay
Copy link
Member

dtolnay commented Oct 9, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 9, 2022

📌 Commit a65ddf0 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2022
@klensy
Copy link
Contributor

klensy commented Oct 9, 2022

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 11, 2022
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#101360 (Point out incompatible closure bounds)
 - rust-lang#101789 (`let`'s not needed in struct field definitions)
 - rust-lang#102846 (update to syn-1.0.102)
 - rust-lang#102871 (rustdoc: clean up overly complex `.trait-impl` CSS selectors)
 - rust-lang#102876 (suggest candidates for unresolved import)
 - rust-lang#102888 (Improve rustdoc-gui search-color test)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 973afb1 into rust-lang:master Oct 11, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 11, 2022
@zertosh zertosh deleted the update-syn branch February 23, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants