Skip to content

Make CStr::from_ptr const. #102961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 29, 2022
Merged

Make CStr::from_ptr const. #102961

merged 3 commits into from
Oct 29, 2022

Conversation

@reitermarkus
Copy link
Contributor

@reitermarkus reitermarkus commented Oct 12, 2022

Should be included in #101719.

cc @WaffleLapkin

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 12, 2022
@rust-highfive
Copy link
Contributor

rust-highfive commented Oct 12, 2022

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Oct 12, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 12, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@reitermarkus
Copy link
Contributor Author

reitermarkus commented Oct 16, 2022

r? @oli-obk since you reviewed #100291.

@rust-highfive rust-highfive assigned oli-obk and unassigned m-ou-se Oct 16, 2022
fee1-dead
fee1-dead reviewed Oct 27, 2022
View reviewed changes
@oli-obk
Copy link
Contributor

oli-obk commented Oct 28, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 28, 2022

📌 Commit b3f9277 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 28, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 28, 2022
@Dylan-DPC
Rollup merge of rust-lang#102961 - reitermarkus:const-cstr-from-ptr, …
6db281a 
…r=oli-obk

Make `CStr::from_ptr` `const`.

Should be included in rust-lang#101719.

cc `@WaffleLapkin`
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 28, 2022
@Dylan-DPC
Rollup merge of rust-lang#102961 - reitermarkus:const-cstr-from-ptr, …
db43536 
…r=oli-obk

Make `CStr::from_ptr` `const`.

Should be included in rust-lang#101719.

cc ``@WaffleLapkin``
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 28, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 29, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 29, 2022
@matthiaskrgr
Rollup merge of rust-lang#102961 - reitermarkus:const-cstr-from-ptr, …
5b45bfe 
…r=oli-obk

Make `CStr::from_ptr` `const`.

Should be included in rust-lang#101719.

cc `@WaffleLapkin`
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 29, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 29, 2022
@bors
Auto merge of rust-lang#103714 - matthiaskrgr:rollup-kajt3i8, r=matth…
33b530e 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#102961 (Make `CStr::from_ptr` `const`.)
 - rust-lang#103342 (Add test for issue 98634)
 - rust-lang#103383 (Note scope of TAIT more accurately)
 - rust-lang#103656 (Specialize ToString for Symbol)
 - rust-lang#103663 (rustdoc: remove redundant CSS/DOM `div.search-container`)
 - rust-lang#103664 (rustdoc-json-types: Improve ItemSummary::path docs)
 - rust-lang#103704 (Add a test for TAIT used with impl/dyn Trait inside RPIT)

Failed merges:

 - rust-lang#103618 (Rename some `OwnerId` fields.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b3ca68f into rust-lang:master Oct 29, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 29, 2022
@reitermarkus reitermarkus deleted the const-cstr-from-ptr branch November 6, 2022 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fee1-dead fee1-dead fee1-dead left review comments

Assignees

@oli-obk oli-obk

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.66.0

Development

Successfully merging this pull request may close these issues.

8 participants

@reitermarkus @rust-highfive @rustbot @rust-log-analyzer @oli-obk @bors @fee1-dead @m-ou-se