-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy up maybe_uninit_slice API #103131
Tidy up maybe_uninit_slice API #103131
Conversation
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
f05b7d2
to
2e10c51
Compare
This comment has been minimized.
This comment has been minimized.
2e10c51
to
f317eaf
Compare
This comment has been minimized.
This comment has been minimized.
c23c0da
to
b11c87b
Compare
This comment has been minimized.
This comment has been minimized.
- Move methods to extensions Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
b11c87b
to
eb667be
Compare
Thanks for the PR! While I'm sometimes willing to add new APIs without libs-api assent, I'm much more worried about churning signatures without contacting them to see if they like them, since it would be a shame to find out they didn't and have to revert it and have impacted nightly users unnecessarily. Could you please file an ACP for this set of changes (I think #103128 #103130 #103131 could probably all be one) to get a "yup, that seems better" from the team? @rustbot author |
☔ The latest upstream changes (presumably #104138) made this pull request unmergeable. Please resolve the merge conflicts. |
@SUPERCILEX @rustbot label: +S-inactive |
Regex replacement:
MaybeUninit::slice_assume_init_(ref|mut)\((?:&mut ?|& ?)?(.*?)\)
->$2.assume_init_$1()