Revert "Normalize opaques with escaping bound vars" #103509

compiler-errors · 2022-10-25T02:19:50Z

This caused a perf regression in #103423, cc @skyzh this should fix #103423.

reverts #100980

r? @oli-obk

compiler-errors · 2022-10-25T02:19:58Z

@bors try @rust-timer queue

rust-timer · 2022-10-25T02:19:59Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

compiler-errors · 2022-10-25T02:20:41Z

@skyzh you should be able to test this using the "try build" that will be created by bors. I can write up instructions to do so, or I might just try building the crate myself.

skyzh · 2022-10-25T02:39:07Z

I can compile this branch of compiler by myself. Hopefully it should be the same as the generated artifacts from bors?

compiler-errors · 2022-10-25T02:39:45Z

Yes, that works too.

bors · 2022-10-25T02:55:42Z

⌛ Trying commit 625500e305c3e8d21c274d85198fb7a09593ffb2 with merge f4d10a74e46baa8f6e56c17fa022b2e8701c6e38...

skyzh · 2022-10-25T03:07:03Z

This fix works on the previous PR I mentioned. Debug builds successfully in 1m 58s. Nearly no regression in time compared with nightly-07-29. Only tested on aarch64-apple-darwin.

bors · 2022-10-25T05:36:03Z

☀️ Try build successful - checks-actions
Build commit: f4d10a74e46baa8f6e56c17fa022b2e8701c6e38 (f4d10a74e46baa8f6e56c17fa022b2e8701c6e38)

rust-timer · 2022-10-25T05:36:05Z

Queued f4d10a74e46baa8f6e56c17fa022b2e8701c6e38 with parent 758f196, future comparison URL.

rust-timer · 2022-10-25T11:52:43Z

Finished benchmarking commit (f4d10a74e46baa8f6e56c17fa022b2e8701c6e38): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.9%	[0.9%, 0.9%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.4%	[-2.1%, -0.2%]	7
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.5%	[-4.5%, -4.5%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.3%, -2.2%]	4
All ❌✅ (primary)	-	-	0

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

lcnr · 2022-10-25T16:30:18Z

I would like to wait with this PR until we get a minimization for this issue. We still have more than 7 weeks until this would hit stable and I think normalizing opaque types with escaping vars is an important improvement to Rust. I fear that by simply reverting this now, we will not take the time to actually search for a MVCE here.

skyzh · 2022-10-25T16:35:30Z

I would like to wait with this PR until we get a minimization for this issue. We still have more than 7 weeks until this would hit stable and I think normalizing opaque types with escaping vars is an important improvement to Rust. I fear that by simply reverting this now, we will not take the time to actually search for a MVCE here.

Sounds good, and I’m still working on it 🤣

skyzh · 2022-10-27T05:17:44Z

MVCE in #103423 (comment)

oli-obk · 2022-11-07T16:03:03Z

@rustbot author

compiler-errors · 2022-11-15T03:08:09Z

I've got some normalization work in the pipeline, but that's 100% not going to get beta backported, so this can/should get landed instead.

@rustbot ready

This reverts commit 43119d6.

rustbot · 2022-11-18T18:33:49Z

The Miri subtree was changed

cc @rust-lang/miri

oli-obk · 2022-11-18T19:39:04Z

@bors r+

bors · 2022-11-18T19:39:06Z

📌 Commit 6ae4e5e has been approved by oli-obk

It is now in the queue for this repository.

bors · 2022-11-19T09:30:39Z

⌛ Testing commit 6ae4e5e with merge 5e6de23...

bors · 2022-11-19T12:44:51Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 5e6de23 to master...

rust-timer · 2022-11-19T14:15:57Z

Finished benchmarking commit (5e6de23): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.6%	[0.3%, 0.8%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.6%	[-2.2%, -0.3%]	6
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.8%	[0.8%, 2.7%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.9%	[-6.3%, -1.2%]	6
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.3%, -2.1%]	4
All ❌✅ (primary)	-	-	0

…mulacrum [beta] backport * Use nominal_obligations_without_const in wf for FnDef rust-lang#104180 * Don't silently eat label before block in block-like expr rust-lang#103986 * Revert "Update CI to use Android NDK r25b" rust-lang#104628 * rustdoc: Resolve doc links in external traits having local impls rust-lang#104364 * Use 64 bits for incremental cache in-file positions rust-lang#104164 * rustdoc: Do not add external traits to the crate in register_res rust-lang#103649 * Revert "Normalize opaques with escaping bound vars" rust-lang#103509 * Bump to released stable compiler * [beta] Update cargo rust-lang#104486 r? `@Mark-Simulacrum`

rylev · 2022-11-22T14:39:54Z

This is a necessary fix for a compiler hang. Additionally the improvements outweigh the regressions and this is all confined to secondary benchmarks.

@rustbot label: +perf-regression-triaged

…-r-hard, r=oli-obk Revert "Normalize opaques with escaping bound vars" This caused a perf regression in rust-lang#103423, cc `@skyzh` this should fix rust-lang#103423. reverts rust-lang#100980 r? `@oli-obk`

rust-highfive assigned oli-obk Oct 25, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 25, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 25, 2022

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 25, 2022

skyzh mentioned this pull request Oct 25, 2022

large number of obligation produced in async code causing compiler stuck #103423

Closed

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 25, 2022

compiler-errors added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2022

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Nov 7, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 15, 2022

compiler-errors added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 15, 2022

rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Nov 18, 2022

compiler-errors added 3 commits November 18, 2022 17:40

Revert "Normalize opaques with escaping bound vars"

b8a92c1

This reverts commit 43119d6.

Add test

c286ad9

Delete miri test

6ae4e5e

compiler-errors force-pushed the opaques-w-bound-vars-r-hard branch from 625500e to 6ae4e5e Compare November 18, 2022 18:33

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2022

compiler-errors mentioned this pull request Nov 19, 2022

Rust does not normalize opaque types with escaping bound vars #104601

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 19, 2022

bors merged commit 5e6de23 into rust-lang:master Nov 19, 2022

rustbot added this to the 1.67.0 milestone Nov 19, 2022

Mark-Simulacrum modified the milestones: 1.67.0, 1.66.0 Nov 20, 2022

Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 20, 2022

Mark-Simulacrum mentioned this pull request Nov 20, 2022

[beta] backport #104447

Merged

rustbot added the perf-regression-triaged The performance regression has been triaged. label Nov 22, 2022

compiler-errors mentioned this pull request Nov 25, 2022

1100% increase (!) in x86_64-unknown-linux release compile times #104842

Closed

compiler-errors mentioned this pull request Feb 3, 2023

Hitting “undefined reference to `core::future::identity_future’” when working with associated types and async #107557

Closed

lcnr mentioned this pull request Feb 17, 2023

performance regressions after stabilization lcnr/solver-woes#1

Open

matthiaskrgr mentioned this pull request Aug 3, 2023

[ICE]: Broken MIR in drop glue with specialization #107228

Closed

4 tasks

compiler-errors deleted the opaques-w-bound-vars-r-hard branch August 11, 2023 20:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Normalize opaques with escaping bound vars" #103509

Revert "Normalize opaques with escaping bound vars" #103509

compiler-errors commented Oct 25, 2022 •

edited by pnkfelix

Loading

compiler-errors commented Oct 25, 2022

rust-timer commented Oct 25, 2022

compiler-errors commented Oct 25, 2022

skyzh commented Oct 25, 2022

compiler-errors commented Oct 25, 2022

bors commented Oct 25, 2022

skyzh commented Oct 25, 2022

bors commented Oct 25, 2022

rust-timer commented Oct 25, 2022

rust-timer commented Oct 25, 2022

lcnr commented Oct 25, 2022 •

edited

Loading

skyzh commented Oct 25, 2022

skyzh commented Oct 27, 2022 •

edited

Loading

oli-obk commented Nov 7, 2022

compiler-errors commented Nov 15, 2022

rustbot commented Nov 18, 2022

oli-obk commented Nov 18, 2022

bors commented Nov 18, 2022

bors commented Nov 19, 2022

bors commented Nov 19, 2022

rust-timer commented Nov 19, 2022

rylev commented Nov 22, 2022

Revert "Normalize opaques with escaping bound vars" #103509

Revert "Normalize opaques with escaping bound vars" #103509

Conversation

compiler-errors commented Oct 25, 2022 • edited by pnkfelix Loading

compiler-errors commented Oct 25, 2022

rust-timer commented Oct 25, 2022

compiler-errors commented Oct 25, 2022

skyzh commented Oct 25, 2022

compiler-errors commented Oct 25, 2022

bors commented Oct 25, 2022

skyzh commented Oct 25, 2022

bors commented Oct 25, 2022

rust-timer commented Oct 25, 2022

rust-timer commented Oct 25, 2022

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

lcnr commented Oct 25, 2022 • edited Loading

skyzh commented Oct 25, 2022

skyzh commented Oct 27, 2022 • edited Loading

oli-obk commented Nov 7, 2022

compiler-errors commented Nov 15, 2022

rustbot commented Nov 18, 2022

oli-obk commented Nov 18, 2022

bors commented Nov 18, 2022

bors commented Nov 19, 2022

bors commented Nov 19, 2022

rust-timer commented Nov 19, 2022

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

rylev commented Nov 22, 2022

compiler-errors commented Oct 25, 2022 •

edited by pnkfelix

Loading

lcnr commented Oct 25, 2022 •

edited

Loading

skyzh commented Oct 27, 2022 •

edited

Loading