Move a wf-check into the site where the value is instantiated #103525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
lcnr
reviewed
Oct 25, 2022
Comment on lines
1297
to
1318
| match impl_.constness { | ||
| hir::Constness::Const => { | ||
| if let Some(trait_def_id) = ast_trait_ref.trait_def_id() && !tcx.has_attr(trait_def_id, sym::const_trait) { | ||
| let trait_name = tcx.item_name(trait_def_id); | ||
| let mut err = tcx.sess.struct_span_err( | ||
| ast_trait_ref.path.span, | ||
| &format!("const `impl` for trait `{trait_name}` which is not marked with `#[const_trait]`"), | ||
| ); | ||
| if trait_def_id.is_local() { | ||
| let sp = tcx.def_span(trait_def_id).shrink_to_lo(); | ||
| err.span_suggestion(sp, &format!("mark `{trait_name}` as const"), "#[const_trait]", rustc_errors::Applicability::MachineApplicable); | ||
| } | ||
| err.note("marking a trait with `#[const_trait]` ensures all default method bodies are `const`"); | ||
| err.note("adding a non-const method body in the future would be a breaking change"); | ||
| err.emit(); | ||
| ty::BoundConstness::NotConst | ||
| } else { | ||
| ty::BoundConstness::ConstIfConst | ||
| } | ||
| }, | ||
| hir::Constness::NotConst => ty::BoundConstness::NotConst, | ||
| }, |
There was a problem hiding this comment.
can you move that out of the instantiate_mono_trait_ref call?
rustbot
added
the
A-translation
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
|
@bors r=lcnr |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 27, 2022
…ait, r=lcnr Move a wf-check into the site where the value is instantiated r? `@lcnr`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 27, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#103035 (Even nicer errors from assert_unsafe_precondition) - rust-lang#103106 (Try to say that memory outside the AM is always exposed) - rust-lang#103475 (Make param index generation a bit more robust) - rust-lang#103525 (Move a wf-check into the site where the value is instantiated) - rust-lang#103564 (library: allow some unused things in Miri) - rust-lang#103586 (Process registered region obligation in `resolve_regions_with_wf_tys`) - rust-lang#103592 (rustdoc: remove redundant CSS selector `.notable-traits .notable`) - rust-lang#103593 (Remove an unused parser function (`Expr::returns`)) - rust-lang#103611 (Add test for issue 103574) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @lcnr