Use .. consistently for ignoring multiple elements in patterns
#10366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This adds a new pattern type |
| let subpat = self.parse_pat(); | ||
| match subpat { | ||
| @ast::Pat { id, node: PatWild, span } => { | ||
| // FIXME #5830 activate after snapshot |
There was a problem hiding this comment.
Could you change this to a NOTE? At least when I've made a snapshot I normally run make tidy to see how much there's left to do (other than git grep stage0)
|
In the test you added, all the old syntax is going away, right? If so, r=me with NOTEs instead of FIXMEs |
@brson can you still do the tail destructuring? ie. |
|
@bjz Yes. |
|
@alexcrichton Yeah, the old syntax is going away. I just threw it all in there to see it all in the same place. |
bors
added a commit
that referenced
this pull request
Nov 19, 2013
This replaces `*` with `..` in enums, `_` with `..` in structs, and `.._` with `..` in vectors. It adds obsolete syntax warnings for the old forms but doesn't turn them on yet because we need a snapshot. #5830
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 6, 2023
fix [`cast_possible_truncation`] offering wrong suggestion for casting float to integer fixes: rust-lang#10366 --- changelog: [`cast_possible_truncation`] Fix incorrect suggestions when casting from float types or to `_`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces
*with..in enums,_with..in structs, and.._with..in vectors. It adds obsolete syntax warnings for the old forms but doesn't turn them on yet because we need a snapshot.#5830