Fix z-indexes of code example feature and cleanup its CSS #103722
Merged
+24
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 30, 2022
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#100006 (Make `core::mem::copy` const) - rust-lang#102659 (1.65.0 release notes) - rust-lang#103124 (Add tests for autoderef on block tail) - rust-lang#103253 (rustdoc: add test case for masked blanket impl) - rust-lang#103715 (use consistent terminology) - rust-lang#103722 (Fix z-indexes of code example feature and cleanup its CSS) - rust-lang#103726 (Avoid unnecessary `&str` to `String` conversions) - rust-lang#103737 (rustdoc: use CSS margin/padding shorthand when all are being set) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reviewing #103650, I realized that the
z-indexes of this feature were completely broken:This PR fixes it by reducing the value of value under the one used for
.popover(it could be completely removed but then it wouldn't be displayed as nicely).There was also a lot of duplicated CSS so I merged the rules.
r? @notriddle