Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove allow(rustc::potential_query_instability) in rustc_trait_selection #103723

Merged
merged 1 commit into from
Nov 9, 2022

Commits on Nov 8, 2022

  1. Reduce the scope of allow(rustc::potential_query_instability) in rust…

    …c_trait_selection
    
    Make InferCtxtExt use a FxIndexMap
    
    This should be faster, because the map is only being used to iterate,
    which is supposed to be faster with the IndexMap
    
    Make the user_computed_preds use an IndexMap
    
    It is being used mostly for iteration, so the change shouldn't result in
    a perf hit
    
    Make the RegionDeps fields use an IndexMap
    
    This change could be a perf hit. Both `larger` and `smaller` are used
    for iteration, but they are also used for insertions.
    
    Make types_without_default_bounds use an IndexMap
    
    It uses extend, but it also iterates and removes items. Not sure if
    this will be a perf hit.
    
    Make InferTtxt.reported_trait_errors use an IndexMap
    
    This change brought a lot of other changes. The map seems to have been
    mostly used for iteration, so the performance shouldn't suffer.
    
    Add FIXME to change ProvisionalEvaluationCache.map to use an IndexMap
    
    Right now this results in a perf hit. IndexMap doesn't have
    the `drain_filter` API, so in `on_completion` we now need to iterate two
    times over the map.
    CastilloDel committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    755ca4b View commit details
    Browse the repository at this point in the history