Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bootstrap compiler to 1.66 #103858

Merged
merged 5 commits into from
Nov 14, 2022
Merged

Conversation

Mark-Simulacrum
Copy link
Member

This PR:

  • Bumps version placeholders to release
  • Bumps to latest beta
  • cfg-steps code

r? @pietroalbini

@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Nov 2, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 2, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-log-analyzer

This comment has been minimized.

@Mark-Simulacrum Mark-Simulacrum force-pushed the bump-bootstrap branch 2 times, most recently from 2e01a41 to b5d6eca Compare November 2, 2022 01:25
@rust-log-analyzer

This comment has been minimized.

@ehuss
Copy link
Contributor

ehuss commented Nov 2, 2022

I think the PR title was intended to be 1.66, not 1.56?

@Mark-Simulacrum Mark-Simulacrum changed the title Bump bootstrap compiler to 1.56 Bump bootstrap compiler to 1.66 Nov 2, 2022
@Mark-Simulacrum
Copy link
Member Author

Alright, CI is passing here, so I think this is ready for review now.

@klensy
Copy link
Contributor

klensy commented Nov 2, 2022

@pietroalbini
Copy link
Member

pietro@backdoor: ~/r/github/rust-lang/rust ((9fdc5f228e9...))$ rg '#!?\[.*\(bootstrap' -t rust
library/core/src/prelude/v1.rs
78:#[cfg(not(bootstrap))]

library/core/tests/mem.rs
80:#[cfg(not(bootstrap))] // stage 0 doesn't have the fix yet, so the test fails

library/core/src/macros/mod.rs
1517:    #[cfg(not(bootstrap))]

[ignoring stdarch]

library/alloc/src/alloc.rs
408:    #[cfg(bootstrap)]

library/std/src/prelude/v1.rs
62:#[cfg(not(bootstrap))]
pietro@backdoor: ~/r/github/rust-lang/rust ((9fdc5f228e9...))$ 

Are those cfgs intentionally skipped?

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2022
@Mark-Simulacrum
Copy link
Member Author

I believe all four were added after we bumped src/version, or at least removing them led to errors.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 3, 2022
@bors
Copy link
Contributor

bors commented Nov 6, 2022

☔ The latest upstream changes (presumably #99943) made this pull request unmergeable. Please resolve the merge conflicts.

@pietroalbini
Copy link
Member

@bors r+ p=10

@bors
Copy link
Contributor

bors commented Nov 13, 2022

📌 Commit 01a2a57 has been approved by pietroalbini

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2022
@bors
Copy link
Contributor

bors commented Nov 14, 2022

⌛ Testing commit 01a2a57 with merge 338cfd3...

@bors
Copy link
Contributor

bors commented Nov 14, 2022

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing 338cfd3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 14, 2022
@bors bors merged commit 338cfd3 into rust-lang:master Nov 14, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 14, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (338cfd3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.0% [3.3%, 5.2%] 4
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
5.0% [3.5%, 6.6%] 6
Regressions ❌
(secondary)
2.3% [1.6%, 3.0%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 5.0% [3.5%, 6.6%] 6

Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
…etroalbini

Bump bootstrap compiler to 1.66

This PR:

- Bumps version placeholders to release
- Bumps to latest beta
- cfg-steps code

r? `@pietroalbini`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants