Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify astconv item def id handling #103875

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Simplify astconv item def id handling #103875

merged 1 commit into from
Nov 3, 2022

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Nov 2, 2022

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Nov 2, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eholk (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 2, 2022
@oli-obk oli-obk marked this pull request as ready for review November 2, 2022 12:04
@spastorino
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 2, 2022

📌 Commit ecea616 has been approved by spastorino

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 2, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 3, 2022
@bors
Auto merge of rust-lang#103903 - matthiaskrgr:rollup-r5xcvrp, r=matth…
96787c4 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#99801 (fix(generic_const_exprs): Fix predicate inheritance for children of opaque types)
 - rust-lang#103610 (Allow use of `-Clto=thin` with `-Ccodegen-units=1` in general)
 - rust-lang#103870 (Fix `inferred_kind` ICE)
 - rust-lang#103875 (Simplify astconv item def id handling)
 - rust-lang#103886 (rustdoc: Fix merge of attributes for reexports of local items)
 - rust-lang#103890 (rustdoc: remove unused mobile CSS `.rustdoc { padding-top: 0 }`)

Failed merges:

 - rust-lang#103884 (Add visit_fn_ret_ty to hir intravisit)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bb201b5 into rust-lang:master Nov 3, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eholk eholk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
5 participants
@oli-obk @rustbot @spastorino @bors @eholk