-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Update cargo" #103922
Revert "Update cargo" #103922
Conversation
This reverts commit 331aa45. This Cargo upgrade introduced a regression into dependency resolution, so reverting the upgrade until we can fix that.
@bors r+ p=30 Going to self-approve this revert since it's literally just undoing a previous change and I want to minimize the chance of this hitting nightly later today (since it seems like it would break lots of builds in practice, unless I'm missing something obvious). Filed rust-lang/cargo#11330 to track fixing it. |
@bors r+ p=30 Maybe will get picked up now... |
⌛ Testing commit 634b9f8 with merge 551da74b251cf18c5870ba912a8f5ef51c0270c9... |
💥 Test timed out |
@bors retry |
This comment was marked as outdated.
This comment was marked as outdated.
☀️ Test successful - checks-actions |
Finished benchmarking commit (215e3cd): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
This reverts commit 331aa45.
This Cargo upgrade introduced a regression into dependency resolution, so reverting the upgrade until we can fix that.
cc #103860,
https://rust-lang.zulipchat.com/#narrow/stream/247081-t-compiler.2Fperformance/topic/cargo.20and.20rustc.20benchmarks.20broken