Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update cargo" #103922

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Revert "Update cargo" #103922

merged 1 commit into from
Nov 4, 2022

Conversation

Mark-Simulacrum
Copy link
Member

This reverts commit 331aa45.

This Cargo upgrade introduced a regression into dependency resolution, so reverting the upgrade until we can fix that.

cc #103860,
https://rust-lang.zulipchat.com/#narrow/stream/247081-t-compiler.2Fperformance/topic/cargo.20and.20rustc.20benchmarks.20broken

This reverts commit 331aa45.

This Cargo upgrade introduced a regression into dependency resolution,
so reverting the upgrade until we can fix that.
@Mark-Simulacrum
Copy link
Member Author

@bors r+ p=30

Going to self-approve this revert since it's literally just undoing a previous change and I want to minimize the chance of this hitting nightly later today (since it seems like it would break lots of builds in practice, unless I'm missing something obvious).

Filed rust-lang/cargo#11330 to track fixing it.

@Mark-Simulacrum
Copy link
Member Author

@bors r+ p=30

Maybe will get picked up now...

@bors
Copy link
Contributor

bors commented Nov 3, 2022

📌 Commit 634b9f8 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 3, 2022
@bors
Copy link
Contributor

bors commented Nov 3, 2022

⌛ Testing commit 634b9f8 with merge 551da74b251cf18c5870ba912a8f5ef51c0270c9...

@bors
Copy link
Contributor

bors commented Nov 3, 2022

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 3, 2022
@lqd
Copy link
Member

lqd commented Nov 3, 2022

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2022
@bors
Copy link
Contributor

bors commented Nov 3, 2022

⌛ Testing commit 634b9f8 with merge 215e3cd...

@rust-log-analyzer

This comment was marked as outdated.

@bors
Copy link
Contributor

bors commented Nov 4, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 215e3cd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 4, 2022
@bors bors merged commit 215e3cd into rust-lang:master Nov 4, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 4, 2022
@Mark-Simulacrum Mark-Simulacrum deleted the revert-cargo branch November 4, 2022 00:52
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (215e3cd): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.6% [-1.6%, -1.6%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.0% [3.0%, 3.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants