Ready to enable android bot to make check #10394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithout help of apk
|
Do we have a plan for the next steps in enabling continuous tests on android? I have a feeling that as soon as we merge this we're going to start piling up the incompatibilities again. It'd be nice to have a bot turned on (if we need it to be) as this gets landed. That being said, if it takes awhile to get that up and running, this certainly looks fine as-is and we could merge it. |
|
I have had experience android breakage many times and fixed urgently to demonstrate from time to time, so I strongly suggest to enable android bot. |
|
I'll modify the bots to test Android next week. Sorry I've been taking so long on this. |
bors
added a commit
that referenced
this pull request
Nov 11, 2013
To enable test on android bot #9120 some tests are disabled and can be fixed further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable test on android bot #9120
some tests are disabled and can be fixed further.