Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search result bottom border color #103988

Merged
merged 2 commits into from
Nov 5, 2022
Merged

Fix search result bottom border color #103988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94ba7f0
Fix search result bottom border color
GuillaumeGomez Nov 4, 2022
666873b
Update GUI test for bottom border color
GuillaumeGomez Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/librustdoc/html/static/css/rustdoc.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,7 +886,7 @@ so that we can apply CSS-filters to change the arrow color in themes */
/* A little margin ensures the browser's outlining of focused links has room to display. */
margin-left: 2px;
margin-right: 2px;
border-bottom: 1px solid var(--border-color);
border-bottom: 1px solid var(--search-result-border-color);
gap: 1em;
}

Expand Down
1 change: 1 addition & 0 deletions src/librustdoc/html/static/css/themes/ayu.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ Original by Dempfi (https://github.com/dempfi/ayu)
--sidebar-link-color: #53b1db;
--sidebar-current-link-background-color: transparent;
--search-result-link-focus-background-color: #3c3c3c;
--search-result-border-color: #aaa3;
--stab-background-color: #314559;
--stab-code-color: #e6e1cf;
--search-color: #fff;
Expand Down
1 change: 1 addition & 0 deletions src/librustdoc/html/static/css/themes/dark.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
--sidebar-link-color: #fdbf35;
--sidebar-current-link-background-color: #444;
--search-result-link-focus-background-color: #616161;
--search-result-border-color: #aaa3;
--stab-background-color: #314559;
--stab-code-color: #e6e1cf;
--search-color: #111;
Expand Down
1 change: 1 addition & 0 deletions src/librustdoc/html/static/css/themes/light.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
--sidebar-link-color: #356da4;
--sidebar-current-link-background-color: #fff;
--search-result-link-focus-background-color: #ccc;
--search-result-border-color: #aaa3;
--stab-background-color: #fff5d6;
--stab-code-color: #000;
--search-color: #000;
Expand Down
6 changes: 3 additions & 3 deletions src/test/rustdoc-gui/search-result-color.goml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ assert-css: (
// Checking the color of the bottom border.
assert-css: (
".search-results > a",
{"border-bottom-color": "rgb(92, 103, 115)"}
{"border-bottom-color": "rgba(170, 170, 170, 0.2)"}
)

// Checking the color of "keyword" text.
Expand Down Expand Up @@ -190,7 +190,7 @@ assert-css: (
// Checking the color of the bottom border.
assert-css: (
".search-results > a",
{"border-bottom-color": "rgb(224, 224, 224)"}
{"border-bottom-color": "rgba(170, 170, 170, 0.2)"}
)

// Checking the color for "keyword" text.
Expand Down Expand Up @@ -287,7 +287,7 @@ assert-css: (
// Checking the color of the bottom border.
assert-css: (
".search-results > a",
{"border-bottom-color": "rgb(224, 224, 224)"}
{"border-bottom-color": "rgba(170, 170, 170, 0.2)"}
)

// Checking the color for "keyword" text.
Expand Down