Normalize types when deducing closure signature from supertraits #104038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
force-pushed
the
super-norm-closure-sig
branch
from
75e2f7b
to
9a1043e
Compare
compiler-errors
commented
Nov 6, 2022
| @@ -241,9 +242,12 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> { | |||
| if expected_sig.is_none() | |||
| && let ty::PredicateKind::Projection(proj_predicate) = bound_predicate.skip_binder() | |||
| { | |||
| expected_sig = self.deduce_sig_from_projection( | |||
| expected_sig = self.normalize_associated_types_in( | |||
There was a problem hiding this comment.
Fold after deduce_sig_from_projection so we only need to normalize the types that end up in the closure sig.
compiler-errors
changed the title
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 7, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#103757 (Mention const and lifetime parameters in error E0207) - rust-lang#103986 (Don't silently eat label before block in block-like expr) - rust-lang#104003 (Move some tests to more reasonable directories) - rust-lang#104038 (Normalize types when deducing closure signature from supertraits) - rust-lang#104052 (Fix `resolution_failure` ICE) - rust-lang#104090 (Modify comment syntax error) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elaborated supertraits should be normalized, since there's no guarantee they don't contain projections 😅
Fixes #104025
r? types