Tighten the 'introduce new binding' suggestion #104186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
chenyukang
force-pushed
the
yukang/fix-104086-let-binding-issue
branch
from
74d112d
to
952df48
Compare
oli-obk
requested changes
Nov 9, 2022
oli-obk
reviewed
Nov 9, 2022
chenyukang
force-pushed
the
yukang/fix-104086-let-binding-issue
branch
from
1bd6af1
to
07381b3
Compare
oli-obk
reviewed
Nov 9, 2022
chenyukang
force-pushed
the
yukang/fix-104086-let-binding-issue
branch
from
07381b3
to
c69872b
Compare
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
cjgillot
reviewed
Nov 10, 2022
| } | ||
| self.visit_expr(lhs); | ||
| self.diagnostic_metadata.is_assign_rhs = true; | ||
| self.diagnostic_metadata.in_assignment = None; |
There was a problem hiding this comment.
Should we reinstate the overwritten value, instead of putting None in all cases?
There was a problem hiding this comment.
we only care about the lhs of assignment.
There was a problem hiding this comment.
And the backup state is not important, the check logic is invoked by visit_expr.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 10, 2022
…earth Rollup of 9 pull requests Successful merges: - rust-lang#101939 (Add loongarch64 abi support) - rust-lang#103863 (Use `TraitEngine` in more places, restrict visibility of `FulfillmentCtxt` constructor) - rust-lang#104036 (Suggest `is_some` when we've found `Option` but expected `bool`) - rust-lang#104060 (Make `Hash`, `Hasher` and `BuildHasher` `#[const_trait]` and make `Sip` const `Hasher`) - rust-lang#104077 (Use aapcs for efiapi calling convention on arm) - rust-lang#104186 (Tighten the 'introduce new binding' suggestion) - rust-lang#104194 (`EarlyBinder` docs) - rust-lang#104233 (Don't ICE when encountering `ConstKind::Error` in `RequiredConstsVisitor`) - rust-lang#104235 (Use `const_error_with_guaranteed` more) Failed merges: - rust-lang#104078 (Print "Checking/Building ..." message even when --dry-run is passed) - rust-lang#104169 (Migrate `:target` rules to use CSS variables) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104086