Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove run-pass/issue-3907-2.rs #10426

Closed
wants to merge 1 commit into from

Conversation

astrieanna
Copy link
Contributor

This test is not supposed to compile; there is an equivalent test in compile-fail/issue-3907.rs.
The relevant issue #3907.

This test is not supposed to compile; there is an equivalent test in compile-fail/issue-3907.rs.
@alexcrichton
Copy link
Member

Could you amend this and possibly some next-related test removals to #10425? We probably don't want to bog down bors too much with these.

@astrieanna
Copy link
Contributor Author

oh, sure. That makes sense. I'm just too used to trying to make commits/PRs that only do one thing at a time.

@astrieanna astrieanna closed this Nov 11, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jun 30, 2023
Port clippy away from compiletest to ui_test

Reasons to do this:

* runs completely on stable Rust
* is easier to extend with new features
* has its own dogfood test suite, so changes can be tested in [the `ui_test` repo](https://github.com/oli-obk/ui_test)
* supports dependencies from crates.io without having to manually fiddle with command line flags
* supports `ui-cargo`, `ui`, `ui-toml` out of the box, no need to find and run the tests ourselves

One thing that is a big difference to `compiletest` is that if a test emits *any* error, you need to mark all of them with `//~ ERROR:` annotations. Since many clippy tests did not have annotations, I changed many lints to be `warn` in their test so that only the `stderr` output is tested.

TODO:

* [ ] check that this still works as a subtree in the rustc repo

changelog: none
<!-- changelog_checked -->

Note: at present the latest changes needed for clippy are only available as a git dependency, but I expect to publish a new crates.io version soon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants