Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fmt::Write to io::Write adapter #104389

Closed
wants to merge 2 commits into from
Closed

Add fmt::Write to io::Write adapter #104389

wants to merge 2 commits into from
+81 −32

Conversation

SUPERCILEX
Copy link
Contributor

@SUPERCILEX SUPERCILEX commented Nov 14, 2022 •
edited
Loading

@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2022

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 14, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@SUPERCILEX
Copy link
Contributor Author

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 14, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@thomcc
Copy link
Member

thomcc commented Nov 14, 2022

This needs an ACP

@thomcc thomcc added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2022
@SUPERCILEX SUPERCILEX mentioned this pull request Nov 14, 2022
Open
@SUPERCILEX
Copy link
Contributor Author

@thomcc Done: rust-lang/libs-team#133

@SUPERCILEX SUPERCILEX force-pushed the fmt branch 4 times, most recently from e75efbd to f5f6de6 Compare November 14, 2022 21:25
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 16, 2023
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. labels Feb 3, 2023
@thomcc thomcc added the S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. label Feb 13, 2023
@thomcc
Copy link
Member

thomcc commented Feb 13, 2023

Re-adding waiting-on-ACP since I can't do anything with it and it's in my review queue otherwise.

@bors
Copy link
Collaborator

bors commented Apr 21, 2023

☔ The latest upstream changes (presumably #110648) made this pull request unmergeable. Please resolve the merge conflicts.

@SUPERCILEX
Copy link
Contributor Author

@rustbot ready. The ACP and this PR should be ready now.

@Dylan-DPC Dylan-DPC removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 17, 2023
@SUPERCILEX
Add fmt::Write to io::Write adapter
2c224d5 
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Relax trait bounds to match the rest of the stdlib (by allowing usele…
88114b8 
…ss construction)

Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX SUPERCILEX mentioned this pull request Dec 4, 2023
Closed
@SUPERCILEX
Copy link
Contributor Author

I just put out a similar proposal for Hashers: rust-lang/libs-team#309

@SUPERCILEX
Copy link
Contributor Author

SUPERCILEX commented Dec 7, 2023 •
edited
Loading

I no longer think this is the appropriate implementation, though I still want composability between writeable traits. In the meantime, I've created this crate which generalizes over adapters, requiring only a single import: https://docs.rs/io-adapters/latest

@SUPERCILEX SUPERCILEX closed this Dec 7, 2023
@SUPERCILEX SUPERCILEX deleted the fmt branch December 27, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a blanket impl for core::fmt::Write if there is an impl for std::io::Write
6 participants
@SUPERCILEX @rustbot @rust-log-analyzer @thomcc @bors @Dylan-DPC