Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interpret: use Either over Result when it is not representing an error condition #104564

Merged
merged 2 commits into from
Nov 20, 2022
Merged

interpret: use Either over Result when it is not representing an error condition #104564

merged 2 commits into from
Nov 20, 2022

Conversation

RalfJung
Copy link
Member

@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 18, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 18, 2022

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

@oli-obk
Copy link
Contributor

oli-obk commented Nov 18, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Nov 18, 2022

📌 Commit 09a887c has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 20, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2022
@bors
Auto merge of rust-lang#104646 - matthiaskrgr:rollup-7xnhzf0, r=matth…
a28f3c8 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#104537 (fix std::thread docs are unclear regarding stack sizes)
 - rust-lang#104558 (Don't assume `FILE_ID_BOTH_DIR_INFO` will be aligned)
 - rust-lang#104564 (interpret: use Either over Result when it is not representing an error condition)
 - rust-lang#104568 (clarify that realloc refreshes pointer provenance even when the allocation remains in-place)
 - rust-lang#104611 (rustdoc: use real buttons for scrape examples controls)
 - rust-lang#104640 (Migrate kdb style to CSS variables)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 820a415 into rust-lang:master Nov 20, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 20, 2022
@RalfJung RalfJung deleted the either branch November 21, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk approved these changes

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
4 participants
@RalfJung @rustbot @oli-obk @bors