enable fuzzy_provenance_casts lint in liballoc and libstd #104647

RalfJung · 2022-11-20T18:23:55Z

rustbot · 2022-11-20T18:24:01Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

RalfJung · 2022-11-20T18:25:22Z

library/std/src/personality/dwarf/eh.rs

@@ -184,7 +185,7 @@ unsafe fn read_encoded_pointer(
    };

    if encoding & DW_EH_PE_indirect != 0 {
-        result = *(result as *const usize);
+        result = *ptr::from_exposed_addr::<usize>(result);


I hope this can only happen if we previously had the DW_EH_PE_pcrel case above and exposed the pointer...

Who knows, but given that as *const usize is essentially semantically equivalent to from_exposed_addr::<usize>(...), this shouldn't add additional UB or anything if that's not how it is.

This could add UB only if the code relied on the round_up stuff above also exposing the pointer. But that did look like a slam-dunk case for with_addr so I went with that. (Actually it would be an awesome case for map_addr except that it would need ? inside the closure so of course that doesn't work...)

This could add UB only if the code relied on the round_up stuff above also exposing the pointer

That would be incredibly goofy and surprising, so I'm going to assume it's not the case.

thomcc · 2022-11-20T18:26:10Z

library/alloc/tests/lib.rs

@@ -47,6 +47,7 @@
 #![feature(strict_provenance)]
 #![feature(once_cell)]
 #![feature(drain_keep_rest)]
+#![deny(fuzzy_provenance_casts)]


A little surprised this is the only lint we turn on in the liballoc tests, but I'll look into that later.

Yeah me too... I briefly tried denying unsafe_op_in_unsafe_fn and got too many red lines to pursue this further right now. ;)

thomcc · 2022-11-20T18:28:28Z

@bors r+ rollup

bors · 2022-11-20T18:28:30Z

📌 Commit 7f5addd has been approved by thomcc

It is now in the queue for this repository.

thomcc · 2022-11-20T18:29:12Z

Ah, wait, this might cause platform-specific failures. So maybe rollup=always is too optimistic.

@bors rollup=maybe

RalfJung · 2022-11-20T18:30:40Z

Ah, wait, this might cause platform-specific failures. So maybe rollup=always is too optimistic.

Yeah. I did check builds on Linux, Android, macOS, Windows targets (which did find some more cases) but there are tons of targets left untested -- this should probably be
@bors rollup=iffy

bors · 2022-11-20T22:31:01Z

⌛ Testing commit 7f5addd with merge 5d1ad57001036df80dc2d48130ba9a461b4a81a6...

bors · 2022-11-20T23:03:15Z

💔 Test failed - checks-actions

RalfJung · 2022-11-21T15:11:31Z

@bors r=thomcc

bors · 2022-11-21T15:11:33Z

📌 Commit 1a69666 has been approved by thomcc

It is now in the queue for this repository.

rust-log-analyzer · 2022-11-21T15:48:13Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  IMAGE: x86_64-gnu-tools
##[endgroup]
From https://github.com/rust-lang/rust
 * branch              master     -> FETCH_HEAD
Searching for toolstate changes between 736c675d2ab65bcde6554e1b73340c2dbc27c85a and 999d40d8101aaba38fb0a99d64656bd6471b8e5a
Tool subtrees were updated
##[group]Run src/ci/scripts/verify-channel.sh
src/ci/scripts/verify-channel.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
---
.......... (80/88)
........   (88/88)


/checkout/src/test/rustdoc-gui/code-sidebar-toggle.goml code-sidebar-toggle... FAILED
[ERROR] (line 4) Error: Execution context was destroyed, most likely because of a navigation.: for command `wait-for: "#sidebar-toggle"`
Build completed unsuccessfully in 0:02:17

RalfJung · 2022-11-21T15:51:28Z

Flaky rustdoc test?

/checkout/src/test/rustdoc-gui/code-sidebar-toggle.goml code-sidebar-toggle... FAILED

Cc @rust-lang/rustdoc

notriddle · 2022-11-21T16:02:43Z

Yeah, flaky rustdoc test. Nothing you changed here could've affected it. #93784

…r=thomcc enable fuzzy_provenance_casts lint in liballoc and libstd r? `@thomcc`

…r=thomcc enable fuzzy_provenance_casts lint in liballoc and libstd r? ``@thomcc``

…r=thomcc enable fuzzy_provenance_casts lint in liballoc and libstd r? ```@thomcc```

…earth Rollup of 6 pull requests Successful merges: - rust-lang#103488 (Allow opaque types in trait impl headers and rely on coherence to reject unsound cases) - rust-lang#104359 (Refactor must_use lint into two parts) - rust-lang#104612 (Lower return type outside async block creation) - rust-lang#104621 (Fix --extern library finding errors) - rust-lang#104647 (enable fuzzy_provenance_casts lint in liballoc and libstd) - rust-lang#104750 (Bump `fd-lock` in `bootstrap` again) Failed merges: - rust-lang#104732 (Refactor `ty::ClosureKind` related stuff) r? `@ghost` `@rustbot` modify labels: rollup

…safe_fn, r=Mark-Simulacrum Add `#![deny(unsafe_op_in_unsafe_fn)]` in liballoc tests In rust-lang#104647 (comment) it was mentioned that liballoc tests should probably have this enabled (we have it pretty much everywhere else in the stdlib), so I added it. This will probably conflict with rust-lang#104647 so I'll rebase after that lands.

…r=Mark-Simulacrum Add `#![deny(unsafe_op_in_unsafe_fn)]` in liballoc tests In rust-lang/rust#104647 (comment) it was mentioned that liballoc tests should probably have this enabled (we have it pretty much everywhere else in the stdlib), so I added it. This will probably conflict with rust-lang/rust#104647 so I'll rebase after that lands.

RalfJung added 2 commits November 20, 2022 19:12

enable fuzzy_provenance_casts lint in liballoc

644a5a3

enable fuzzy_provenance_casts lint in libstd

7f5addd

rustbot assigned thomcc Nov 20, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 20, 2022

RalfJung commented Nov 20, 2022

View reviewed changes

thomcc reviewed Nov 20, 2022

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2022

thomcc mentioned this pull request Nov 20, 2022

Add #![deny(unsafe_op_in_unsafe_fn)] in liballoc tests #104654

Merged

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 20, 2022

This comment has been minimized.

Sign in to view

dont attempt strict provenance in SGX

1a69666

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2022

notriddle mentioned this pull request Nov 21, 2022

rustdoc-gui tests sporadically failing #93784

Open

Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 22, 2022

Rollup merge of rust-lang#104647 - RalfJung:alloc-strict-provenance, …

7c56974

…r=thomcc enable fuzzy_provenance_casts lint in liballoc and libstd r? `@thomcc`

Manishearth mentioned this pull request Nov 22, 2022

Rollup of 11 pull requests #104738

Closed

Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 22, 2022

Rollup merge of rust-lang#104647 - RalfJung:alloc-strict-provenance, …

ba47cf7

…r=thomcc enable fuzzy_provenance_casts lint in liballoc and libstd r? ``@thomcc``

Manishearth mentioned this pull request Nov 22, 2022

Rollup of 10 pull requests #104749

Closed

Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 23, 2022

Rollup merge of rust-lang#104647 - RalfJung:alloc-strict-provenance, …

8aa6ab8

…r=thomcc enable fuzzy_provenance_casts lint in liballoc and libstd r? ```@thomcc```

This was referenced Nov 23, 2022

Rollup of 7 pull requests #104756

Closed

Rollup of 6 pull requests #104758

Merged

bors merged commit 316bda8 into rust-lang:master Nov 23, 2022

rustbot added this to the 1.67.0 milestone Nov 23, 2022

RalfJung deleted the alloc-strict-provenance branch December 2, 2022 11:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enable fuzzy_provenance_casts lint in liballoc and libstd #104647

enable fuzzy_provenance_casts lint in liballoc and libstd #104647

RalfJung commented Nov 20, 2022

rustbot commented Nov 20, 2022

RalfJung Nov 20, 2022

thomcc Nov 20, 2022

RalfJung Nov 20, 2022

thomcc Nov 20, 2022

thomcc Nov 20, 2022

RalfJung Nov 20, 2022

thomcc commented Nov 20, 2022

bors commented Nov 20, 2022

thomcc commented Nov 20, 2022 •

edited

Loading

RalfJung commented Nov 20, 2022

bors commented Nov 20, 2022

bors commented Nov 20, 2022

This comment has been minimized.

RalfJung commented Nov 21, 2022

bors commented Nov 21, 2022

rust-log-analyzer commented Nov 21, 2022

RalfJung commented Nov 21, 2022

notriddle commented Nov 21, 2022 •

edited

Loading

enable fuzzy_provenance_casts lint in liballoc and libstd #104647

enable fuzzy_provenance_casts lint in liballoc and libstd #104647

Conversation

RalfJung commented Nov 20, 2022

rustbot commented Nov 20, 2022

RalfJung Nov 20, 2022

Choose a reason for hiding this comment

thomcc Nov 20, 2022

Choose a reason for hiding this comment

RalfJung Nov 20, 2022

Choose a reason for hiding this comment

thomcc Nov 20, 2022

Choose a reason for hiding this comment

thomcc Nov 20, 2022

Choose a reason for hiding this comment

RalfJung Nov 20, 2022

Choose a reason for hiding this comment

thomcc commented Nov 20, 2022

bors commented Nov 20, 2022

thomcc commented Nov 20, 2022 • edited Loading

RalfJung commented Nov 20, 2022

bors commented Nov 20, 2022

bors commented Nov 20, 2022

This comment has been minimized.

RalfJung commented Nov 21, 2022

bors commented Nov 21, 2022

rust-log-analyzer commented Nov 21, 2022

RalfJung commented Nov 21, 2022

notriddle commented Nov 21, 2022 • edited Loading

thomcc commented Nov 20, 2022 •

edited

Loading

notriddle commented Nov 21, 2022 •

edited

Loading