Fix UI issues with Rustdoc scrape-examples feature. #104967
Conversation
|
r? @jsha (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
|
Also a heads up: now that there is momentum on the Cargo side (rust-lang/cargo#10343 was merged!), I am currently pushing to get this feature ready for deployment on docs.rs. I will have a separate PR soon on this repo with some UI improvements, but this PR will just focus on fixing bugs. |
* Help file was being loaded from the wrong place. * CSS selector in JS has a typo. * Line numbers are overflowing, change to display: grid to fix.
willcrichton
force-pushed
the
fix-scrape-examples
branch
from
c127493
to
83ba425
Compare
|
Can a regression test case be added alongside https://github.com/rust-lang/rust/blob/master/src/test/rustdoc-gui/scrape-examples-button-focus.goml for the “.next” button? |
|
I just added a test for the .next/.prev buttons. |
|
This PR is ready for review whenever y'all get a chance! @jsha or @notriddle |
|
@bors r=notriddle |
|
@willcrichton: 🔑 Insufficient privileges: Not in reviewers |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
Rollup of 10 pull requests Successful merges: - rust-lang#104967 (Fix UI issues with Rustdoc scrape-examples feature.) - rust-lang#105207 (interpret: clobber return place when calling function) - rust-lang#105246 (Fix --pass in compiletest) - rust-lang#105256 (Add small comment explaining what `method-margins.goml` test is about) - rust-lang#105289 (Fix dupe word typos) - rust-lang#105309 (rustdoc: remove no-op mobile CSS `.sidebar { margin: 0; padding: 0 }`) - rust-lang#105313 (Update books) - rust-lang#105315 (Normalize inherent associated types after substitution) - rust-lang#105324 (Point at GAT `where` clause when an obligation is unsatisfied) - rust-lang#105338 (Tweak "the following other types implement trait") Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
A few regressions have been introduced into scrape-examples in the last few months. This commit fixes those regressions: