Skip to content

Remove Crate::primitives field #104984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 28, 2022
Merged

Remove Crate::primitives field #104984

merged 2 commits into from
Nov 28, 2022

Conversation

GuillaumeGomez
Copy link
Member

It is a new approach to #90447. Instead of removing primitives from everywhere (ie from BadImplStripper), I just removed them from the Crate type, allowing to reduce its size.

cc @camelid
r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 27, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 27, 2022

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

@GuillaumeGomez
Copy link
Member Author

It shouldn't have much impact on performance but just in case:

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 27, 2022
@bors
Copy link
Collaborator

bors commented Nov 27, 2022

⌛ Trying commit 23c3941 with merge 1d08eb3bd7ded4d7a30b94be88a6a1c100af8084...

@bors
Copy link
Collaborator

bors commented Nov 27, 2022

☀️ Try build successful - checks-actions
Build commit: 1d08eb3bd7ded4d7a30b94be88a6a1c100af8084 (1d08eb3bd7ded4d7a30b94be88a6a1c100af8084)

1 similar comment
@bors
Copy link
Collaborator

bors commented Nov 27, 2022

☀️ Try build successful - checks-actions
Build commit: 1d08eb3bd7ded4d7a30b94be88a6a1c100af8084 (1d08eb3bd7ded4d7a30b94be88a6a1c100af8084)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1d08eb3bd7ded4d7a30b94be88a6a1c100af8084): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 27, 2022
@GuillaumeGomez
Copy link
Member Author

As expected, no perf changes. Still one field less though. :)

@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 27, 2022

📌 Commit 23c3941 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 27, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 28, 2022
@bors
Auto merge of rust-lang#104990 - matthiaskrgr:rollup-oskk8v3, r=matth…
8c6bf2b 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#104955 (Switch rustdoc-gui test to function call)
 - rust-lang#104976 (Prefer doc comments over `//`-comments in compiler)
 - rust-lang#104984 (Remove Crate::primitives field)
 - rust-lang#104989 (update Miri)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5ea36cf into rust-lang:master Nov 28, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 28, 2022
@GuillaumeGomez GuillaumeGomez deleted the remote-crate-primitives branch November 28, 2022 10:27
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#104990 - matthiaskrgr:rollup-oskk8v3, r=matth…
10eb88f 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#104955 (Switch rustdoc-gui test to function call)
 - rust-lang#104976 (Prefer doc comments over `//`-comments in compiler)
 - rust-lang#104984 (Remove Crate::primitives field)
 - rust-lang#104989 (update Miri)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @rustbot @rust-timer @bors @notriddle