-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 9 pull requests #105059
Closed
Closed
Rollup of 9 pull requests #105059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They can cause issues in e.g. cargo.
This caught a real, existing bug.
…ated-string-comment, r=Mark-Simulacrum Add slice to the stack allocated string comment Precise that the "stack allocated string" is not a string but a string slice. `@rustbot` label +A-docs
…leywiser Don't use periods in target names Using a period in the target name can cause issues in e.g. cargo, see also https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Running.20tests.20on.20remote.20target
…s, r=compiler-errors Print all features with --print target-features This fixes `rustc --print target-features` with respect to aliases and tied features. Before this change, the print command assumed that each LLVM feature corresponds exactly to one rustc feature. In the case of aliases and tied features, this assumption failed and some features (such as aarch64's "pacg") were missing. With this change, every target feature is listed.
…-return-clause, r=oli-obk Make inferred_outlives_crate return Clause r? `@oli-obk`
Don't silently ignore errors that happen during rendering This caught a real, existing bug. Found in rust-lang#104994
Add `PathBuf::as_mut_os_string` and `Path::as_mut_os_str` Implements rust-lang/libs-team#140 (tracking issue rust-lang#105021).
…r=wesleywiser Statics used in reachable function's inline asm are reachable Fixes rust-lang#104925.
Hermit: Minor build fixes These changes are necessary to build for the hermit targets. CC: `@stlankes`
Remove useless borrows and derefs They are nothing more than noise. <sub>These are not all of them, but my clippy started crashing (stack overflow), so rip :(</sub>
@bors r+ rollup=never p=9 |
⌛ Testing commit 9126103 with merge fc136d17fd9b5f21734db032f5c2e426e01c5519... |
💔 Test failed - checks-actions |
The job Click to see the possible cause of the failure (guessed by this bot)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-query-system
Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)
A-testsuite
Area: The testsuite used to check the correctness of rustc
A-translation
Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic
rollup
A PR which is a rollup
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
PathBuf::as_mut_os_string
andPath::as_mut_os_str
#105002 (AddPathBuf::as_mut_os_string
andPath::as_mut_os_str
)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup