Don't make tags for our dependencies and tests. #10508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Largely, this is just being more specific about where tags get searched for to remove external dependencies like src/llvm, which reduces the number of tags *enormously* and significantly increases the usefulness of the tags file as it is then focusing on 240K lines of Rust code and 4.5K of C++ rather than just shy of 1M lines of C++ code (mostly from LLVM) and another 100K lines of Rust tests and a diverse collection of other languages. src/rustllvm/RustWrapper.cpp and src/rustllvm/PassWrapper.cpp are getting tags made, but I'm not sure if that's desirable or not. At worst, it's not a significant wrong. A future, desirable step is producing tags for just libstd and libextra for the use of people using Rust-the-language rather than working on Rust itself.
bors
added a commit
that referenced
this pull request
Nov 18, 2013
Largely, this is just being more specific about where tags get searched for to remove external dependencies like src/llvm, which reduces the number of tags *enormously* and significantly increases the usefulness of the tags file as it is then focusing on 240K lines of Rust code and 4.5K of C++ rather than just shy of 1M lines of C++ code (mostly from LLVM) and another 100K lines of Rust tests and a diverse collection of other languages. src/rustllvm/RustWrapper.cpp and src/rustllvm/PassWrapper.cpp are getting tags made, but I'm not sure if that's desirable or not. At worst, it's not a significant wrong. A future, desirable step is producing tags for just libstd and libextra for the use of people using Rust-the-language rather than working on Rust itself.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 20, 2025
By assuming that a recursive type is normalizable within the deeper calls to `is_normalizable_helper()`, more cases can be handled by this function. In order to fix stack overflows, a recursion limit has also been added for recursive generic type instantiations. Fix rust-lang#9798 Fix rust-lang#10508 Fix rust-lang#11915 changelog: [`large_enum_variant`]: more precise detection of variants with large size differences
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Largely, this is just being more specific about where tags get searched
for to remove external dependencies like src/llvm, which reduces the
number of tags enormously and significantly increases the usefulness
of the tags file as it is then focusing on 240K lines of Rust code
and 4.5K of C++ rather than just shy of 1M lines of C++ code (mostly
from LLVM) and another 100K lines of Rust tests and a diverse collection
of other languages.
src/rustllvm/RustWrapper.cpp and src/rustllvm/PassWrapper.cpp are
getting tags made, but I'm not sure if that's desirable or not. At
worst, it's not a significant wrong.
A future, desirable step is producing tags for just libstd and libextra
for the use of people using Rust-the-language rather than working on
Rust itself.