Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: clean up sidebar link CSS #105086

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

notriddle
Copy link
Contributor

Group text-overflow: ellipses along with white-space: nowrap. It makes no sense to try to apply it to links with overflow-wrap: anywhere, because it can't actually make ellipses when that's turned on.

Simplify the selector for the 25rem left padding on sidebar links, to match up with the style for the container left padding that makes room for it.

Group `text-overflow: ellipses` along with `white-space: nowrap`. It makes
no sense to try to apply it to links with `overflow-wrap: anywhere`, because
it can't actually make ellipses when that's turned on.

Simplify the selector for the 25rem left padding on sidebar links, to match
up with the style for the container left padding that makes room for it.
@rustbot
Copy link
Collaborator

rustbot commented Nov 30, 2022

Failed to set assignee to CraftSpider: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot
Copy link
Collaborator

rustbot commented Nov 30, 2022

r? @CraftSpider

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 30, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 30, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@GuillaumeGomez
Copy link
Member

Thanks! r=me once CI pass.

Also I really need to investigate about this rustbot error.

@notriddle
Copy link
Contributor Author

@bors r=GuillaumeGomez rollup

@bors
Copy link
Contributor

bors commented Nov 30, 2022

📌 Commit 3a61ab6 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 30, 2022
…=GuillaumeGomez

rustdoc: clean up sidebar link CSS

Group `text-overflow: ellipses` along with `white-space: nowrap`. It makes no sense to try to apply it to links with `overflow-wrap: anywhere`, because it can't actually make ellipses when that's turned on.

Simplify the selector for the 25rem left padding on sidebar links, to match up with the style for the container left padding that makes room for it.
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 1, 2022
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#103065 (rustdoc-json: Document and Test that args can be patterns.)
 - rust-lang#104865 (Don't overwrite local changes when updating submodules)
 - rust-lang#104895 (Avoid Invalid code suggested when encountering unsatisfied trait bounds in derive macro code)
 - rust-lang#105063 (Rustdoc Json Tests: Don't assume that core::fmt::Debug will always have one item.)
 - rust-lang#105064 (rustdoc: add comment to confusing CSS `main { min-width: 0 }`)
 - rust-lang#105074 (Add Nicholas Bishop to `.mailmap`)
 - rust-lang#105081 (Add a regression test for rust-lang#104322)
 - rust-lang#105086 (rustdoc: clean up sidebar link CSS)
 - rust-lang#105091 (add Tshepang Mbambo to .mailmap)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e005d04 into rust-lang:master Dec 1, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 1, 2022
@notriddle notriddle deleted the notriddle/sidebar-css branch December 1, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants