Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make VecDeque::new const #105127

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Make VecDeque::new const #105127

merged 1 commit into from
Dec 20, 2022

Conversation

Sp00ph
Copy link
Member

@Sp00ph Sp00ph commented Dec 1, 2022

(See #105072)

@rustbot
Copy link
Collaborator

rustbot commented Dec 1, 2022

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 1, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 1, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@Sp00ph
Copy link
Member Author

Sp00ph commented Dec 1, 2022

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 1, 2022
@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-testsuite Area: The testsuite used to check the correctness of rustc labels Dec 1, 2022
@Sp00ph
Copy link
Member Author

Sp00ph commented Dec 1, 2022

Had a little issue with git, should be good now.

@rustbot label -A-bootstrap -A-testsuite

@rustbot rustbot removed T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-testsuite Area: The testsuite used to check the correctness of rustc labels Dec 1, 2022
@dtolnay dtolnay assigned dtolnay and unassigned Mark-Simulacrum Dec 1, 2022
@dtolnay
Copy link
Member

dtolnay commented Dec 1, 2022

@rust-lang/libs-api:
@rfcbot fcp merge

This PR changes the stable VecDeque::new constructor to be callable in const, and immediately stabilizes that. I don't feel there is a need to land this const as unstable first. The closely related Vec::new has been callable in const on stable for a long time.

https://doc.rust-lang.org/nightly/std/collections/struct.VecDeque.html#method.new

@rfcbot
Copy link

rfcbot commented Dec 1, 2022 •
edited by dtolnay
Loading

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Dec 1, 2022
@dtolnay dtolnay mentioned this pull request Dec 1, 2022
Closed
@Sp00ph Sp00ph mentioned this pull request Dec 5, 2022
Closed
@Sp00ph
Copy link
Member Author

Sp00ph commented Dec 20, 2022

Is there anything blocking this or are we just waiting on one more reviewer to tick their box?

@dtolnay
Copy link
Member

dtolnay commented Dec 20, 2022

I'm gonna take the liberty of checking @yaahc's box because she has stepped down from T-libs-api. This PR would be in FCP already if the checkbox list were accurate.

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Dec 20, 2022
@rfcbot
Copy link

rfcbot commented Dec 20, 2022

🔔 This is now entering its final comment period, as per the review above. 🔔

@dtolnay
Copy link
Member

dtolnay commented Dec 20, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Dec 20, 2022

📌 Commit 2fba078 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2022
@bors
Copy link
Contributor

bors commented Dec 20, 2022

⌛ Testing commit 2fba078 with merge 1d12c3c...

@bors
Copy link
Contributor

bors commented Dec 20, 2022

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing 1d12c3c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 20, 2022
@bors bors merged commit 1d12c3c into rust-lang:master Dec 20, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 20, 2022
@bors bors mentioned this pull request Dec 21, 2022
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1d12c3c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

@joboet joboet mentioned this pull request Dec 23, 2022
Closed
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Dec 30, 2022
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jan 5, 2023
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#105127 - Sp00ph:const_new, r=dtolnay
b043cc3 
Make `VecDeque::new` const

(See rust-lang#105072)
@scottmcm scottmcm added the relnotes Marks issues that should be documented in the release notes of the next release. label Jan 9, 2023
overvenus added a commit to overvenus/tikv that referenced this pull request Jan 3, 2024
@overvenus
fix test_storage_cache_size_change
047cf2d 
VecDeque no longer has initial capacity
See rust-lang/rust#105127

Signed-off-by: Neil Shen <overvenus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. merged-by-bors This PR was explicitly merged by bors. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
9 participants
@Sp00ph @rustbot @dtolnay @rfcbot @bors @rust-timer @Mark-Simulacrum @apiraino @scottmcm