Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to the macos-12-xl builder #105212

Merged
merged 1 commit into from
Dec 3, 2022
Merged

Conversation

pietroalbini
Copy link
Member

This PR switches us to the macos-12-xl builders, a more powerful builder pool managed by GitHub for us.

@rustbot
Copy link
Collaborator

rustbot commented Dec 3, 2022

r? @jyn514

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 3, 2022
@pietroalbini
Copy link
Member Author

Let's see how good they run.

@bors try

@bors
Copy link
Contributor

bors commented Dec 3, 2022

⌛ Trying commit 08020c9c9973e7eddee7c0aafd03d18f9b7d4844 with merge d4dedbdebbfe21c6285008640ae779af4f0bd7f7...

@bors
Copy link
Contributor

bors commented Dec 3, 2022

☀️ Try build successful - checks-actions
Build commit: d4dedbdebbfe21c6285008640ae779af4f0bd7f7 (d4dedbdebbfe21c6285008640ae779af4f0bd7f7)

@jyn514
Copy link
Member

jyn514 commented Dec 3, 2022

hour and 9 minutes! 🎉

@pietroalbini
Copy link
Member Author

Removed the do-not-merge commit. This is ready for review.

@jyn514
Copy link
Member

jyn514 commented Dec 3, 2022

@bors r+ p=15 speeds up CI for all PRs

@bors
Copy link
Contributor

bors commented Dec 3, 2022

📌 Commit fcbae98 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2022
@bors
Copy link
Contributor

bors commented Dec 3, 2022

⌛ Testing commit fcbae98 with merge 2341517...

@bors
Copy link
Contributor

bors commented Dec 3, 2022

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing 2341517 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 3, 2022
@bors bors merged commit 2341517 into rust-lang:master Dec 3, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 3, 2022
@pietroalbini pietroalbini deleted the pa-macos-xl branch December 3, 2022 22:01
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2341517): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.8% [0.8%, 0.8%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.0% [-2.4%, -1.7%] 2
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants