Simplify attribute handling in rustc_ast_lowering #105343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that attributes is stored in a separate BTreeMap, it's not necessary to pass it in when constructing `hir::Expr`. We can just construct `hir::Expr` and then call `self.lower_attrs` later if it needs attributes. As most desugaring code don't use attributes, this allows some code cleanup.
|
r? @fee1-dead (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 8, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#105267 (Don't ICE in ExprUseVisitor on FRU for non-existent struct) - rust-lang#105343 (Simplify attribute handling in rustc_ast_lowering) - rust-lang#105368 (Remove more `ref` patterns from the compiler) - rust-lang#105400 (normalize before handling simple checks for evaluatability of `ty::Const`) - rust-lang#105403 (rustdoc: simplify CSS selectors for item table `.stab`) - rust-lang#105418 (fix: remove hack from link.rs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that attributes is stored in a separate BTreeMap, it's not necessary to pass it in when constructing
hir::Expr. We can just constructhir::Exprand then callself.lower_attrslater if it needs attributes.As most desugaring code don't use attributes, this allows some code cleanup.