Rollup of 9 pull requests #105378
Rollup of 9 pull requests #105378
Conversation
…tive binding in shorthand scenario
fmt add a comment
This code uses a special `hideme` class anyway, so just style that.
…source_scope` method
Replaces using `ResumeTy` / `get_context` in favor of using `&'static mut Context<'_>`. Usage of the `'static` lifetime here is technically "cheating", and replaces the raw pointer in `ResumeTy` and the `get_context` fn that pulls the correct lifetimes out of thin air.
…sleywiser Put all cached values into a central struct instead of just the stable hash cc `@nnethercote` this allows re-use of the type for Predicate without duplicating all the logic for the non-hash cached fields
Fix `emit_unused_delims_expr` ICE Fixes rust-lang#104897 This is also related to rust-lang#104433.
…d, r=eholk Suggest removing struct field from destructive binding only in shorthand scenario Fixes rust-lang#105028
Replace usage of `ResumeTy` in async lowering with `Context` Replaces using `ResumeTy` / `get_context` in favor of using `&'static mut Context<'_>`. Usage of the `'static` lifetime here is technically "cheating", and replaces the raw pointer in `ResumeTy` and the `get_context` fn that pulls the correct lifetimes out of thin air. fixes rust-lang#104828 and rust-lang#104321 (comment) r? `@oli-obk`
…verage, r=cjgillot Add -Z maximal-hir-to-mir-coverage flag This PR adds a new unstable flag `-Z maximal-hir-to-mir-coverage` that changes the behavior of `maybe_lint_level_root_bounded`, pursuant to [a discussion on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Mapping.20MIR.20to.20HIR). When enabled, this function will not search upwards for a lint root, but rather immediately return the provided HIR node ID. This change increases the granularity of the mapping between MIR locations and HIR nodes inside the `SourceScopeLocalData` data structures. This increase in granularity is useful for rustc consumers like [Flowistry](https://github.com/willcrichton/flowistry) that rely on getting source-mapping information about the MIR CFG that is as precise as possible. A test `maximal_mir_to_hir_coverage.rs` has been added to verify that this flag does not break anything. r? `@cjgillot` cc `@gavinleroy`
…-hideme-2, r=GuillaumeGomez rustdoc: simplify CSS selectors on top-doc and non-exhaustive toggles This code uses a special `hideme` class anyway, so just style that.
…fn-ptr-arg, r=cjgillot Point at args in associated const fn pointers Tiny follow-up to rust-lang#105201, not so sure it's worth it but 🤷 The UI test example is a bit more compelling when it's `GlUniformScalar::FACTORY` r? `@cjgillot`
Cleanup macro-expanded code in `rustc_type_ir` We could of course just leave this as-is, but every time I go-to-def to this file it's painful to see all this `(&A(ref __self_1_0),)` stuff.
Remove outdated syntax from trait alias pretty printing
Given the following program:
```rust
#![feature(trait_alias)]
trait A = ?Sized;
fn main() {}
```
Old output of `rustc +nightly ./t.rs -Zunpretty=normal`:
```rust
#![feature(trait_alias)]
trait A for ? Sized ;
fn main() {}
```
New output of `rustc +a ./t.rs -Zunpretty=normal`:
```rust
#![feature(trait_alias)]
trait A = ?Sized;
fn main() {}
```
cc `@durka` (you've written the `FIXME` in rust-lang#45047, see rust-lang#45047 (comment))
rustbot
added
S-waiting-on-review
bors
added
S-waiting-on-bors
|
@bors p=9 |
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: e60fbaf4ce In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (b28d30e): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
|
NOTE to whoever might triage this regression: The changes to This is a bit surprising to me though, I would have expected this to rather further improve things if anything, as it removes a fn call in favor of a more complex but also more correct type. |
|
@rust-timer build 19a19284681762447cbed6f2543fd83583612d19 |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (19a19284681762447cbed6f2543fd83583612d19): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Successful merges:
emit_unused_delims_exprICE #105004 (Fixemit_unused_delims_exprICE)ResumeTyin async lowering withContext#105250 (Replace usage ofResumeTyin async lowering withContext)rustc_type_ir#105362 (Cleanup macro-expanded code inrustc_type_ir)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup