Inline and remove place_contents_drop_state_cannot_differ.

[nnethercote]

It has a single call site and is hot enough to be worth inlining. And make sure is_terminal_path is inlined, too.

r? @ghost

[nnethercote]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 68a1920 with merge a71692e2465d7363b500637adeeecfa163b82e1a...

[bors]

☀️ Try build successful - checks-actions
Build commit: a71692e2465d7363b500637adeeecfa163b82e1a (a71692e2465d7363b500637adeeecfa163b82e1a)

[rust-timer]

Finished benchmarking commit (a71692e2465d7363b500637adeeecfa163b82e1a): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.8%	[-0.9%, -0.7%]	9
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.8%	[2.8%, 2.8%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.8%	[2.8%, 2.8%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.6%, 0.6%]	1
Regressions ❌ (secondary)	3.1%	[3.1%, 3.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[0.6%, 0.6%]	1

[nnethercote]

This was also a small win on the aws-sdk-ec2 crate when I measured it locally.

r? @spastorino

[spastorino]

@bors r+

[bors]

📌 Commit 68a1920 has been approved by spastorino

It is now in the queue for this repository.

[bors]

⌛ Testing commit 68a1920 with merge 71ec145...

[bors]

☀️ Test successful - checks-actions
Approved by: spastorino
Pushing 71ec145 to master...

[rust-timer]

Finished benchmarking commit (71ec145): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.8%	[-1.2%, -0.4%]	3
Improvements ✅ (secondary)	-2.2%	[-2.6%, -2.0%]	6
All ❌✅ (primary)	-0.8%	[-1.2%, -0.4%]	3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.7%	[0.8%, 2.6%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.0%	[-6.6%, -2.4%]	3
All ❌✅ (primary)	1.7%	[0.8%, 2.6%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

[lqd]

These post-merge results are different from the pre-merge perf run, they now look like steady-state perturbations on these benchmarks, that have since stabilized in #105350 (comment).

[nnethercote]

This gave a small win locally for the aws-sdk-ec2 crate, a win larger than any improvement I saw for the rustc-perf benchmarks.