Move some codegen-y methods from rustc_hir_analysis::collect -> rustc_codegen_ssa
#105438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-translation
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
compiler-errors
force-pushed
the
move-methods
branch
from
8c1a86a to
1c4af5f
Compare
estebank
reviewed
Dec 8, 2022
compiler-errors
force-pushed
the
move-methods
branch
from
1c4af5f to
1758ae1
Compare
|
☔ The latest upstream changes (presumably #105525) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r=me |
compiler-errors
force-pushed
the
move-methods
branch
from
1758ae1 to
a8a4510
Compare
|
@bors r=estebank |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Dec 13, 2022
…tebank Move some codegen-y methods from `rustc_hir_analysis::collect` -> `rustc_codegen_ssa` Unclear if they should live here, but they seem codegen-y enough, and `rustc_hir_analysis::collect` is extremely long, so it should probably lose some methods.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 13, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#105147 (Allow unsafe through inline const) - rust-lang#105438 (Move some codegen-y methods from `rustc_hir_analysis::collect` -> `rustc_codegen_ssa`) - rust-lang#105464 (Support #[track_caller] on async closures) - rust-lang#105476 (Change pattern borrowing suggestions to be verbose and remove invalid suggestion) - rust-lang#105500 (Make some diagnostics not depend on the source of what they reference being available) - rust-lang#105628 (Small doc fixes) - rust-lang#105659 (Don't require owned data in `MaybeStorageLive`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unclear if they should live here, but they seem codegen-y enough, and
rustc_hir_analysis::collectis extremely long, so it should probably lose some methods.