Skip to content

Conversation

notriddle
Copy link
Contributor

@notriddle notriddle commented Dec 9, 2022

Before

image

image

After

image

image

Description

  • They all get rounded corners now. A test case has been added for this, too.

  • There are now broadly two kinds of stability badge, where there used to be three: item-info "fat badge", and the "thin badge" in both item tables and in docblocks (which got merged). The fat badges can have icons, while the thin badges can't.

  • The old Ayu design doesn't make sense to me. Does anyone know why it was done that way?

* They all get rounded corners now. A test case has been added for this, too.

* There are now broadly two kinds of stability badge, where there used to be
  three: item-info "fat badge", and the "thin badge" in both item tables and
  in docblocks (which got merged). The fat badges can have icons, while the
  thin badges can't.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 9, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 9, 2022

A change occurred in the Ayu theme.

cc @Cldfire

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

Some changes occurred in HTML/CSS themes.

cc @GuillaumeGomez

@GuillaumeGomez
Copy link
Member

Thanks! r=me once CI pass

@notriddle
Copy link
Contributor Author

@bors r=GuillaumeGomez rollup

@bors
Copy link
Collaborator

bors commented Dec 9, 2022

📌 Commit d60967b has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 9, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 10, 2022
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#102406 (Make `missing_copy_implementations` more cautious)
 - rust-lang#105265 (Add `rustc_on_unimplemented` to `Sum` and `Product` trait.)
 - rust-lang#105385 (Skip test on s390x as LLD does not support the platform)
 - rust-lang#105453 (Make `VecDeque::from_iter` O(1) from `vec(_deque)::IntoIter`)
 - rust-lang#105468 (Mangle "main" as "__main_void" on wasm32-wasi)
 - rust-lang#105480 (rustdoc: remove no-op mobile CSS `#sidebar-toggle { text-align }`)
 - rust-lang#105489 (Fix typo in apple_base.rs)
 - rust-lang#105504 (rustdoc: make stability badge CSS more consistent)
 - rust-lang#105506 (Tweak `rustc_must_implement_one_of` diagnostic output)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d0563c6 into rust-lang:master Dec 10, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 10, 2022
@notriddle notriddle deleted the notriddle/stab-css branch December 13, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants