Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest collecting into Vec<_> #105523

Merged
merged 6 commits into from
Dec 14, 2022
Merged

Suggest collecting into Vec<_> #105523

merged 6 commits into from
Dec 14, 2022

Commits on Dec 13, 2022

  1. Suggest collecting into Vec<_>

    @estebank
    estebank committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    9d5e7d3 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary code and account for turbofish suggestion 

    Remove previously existing fallback that tried to give a good turbofish
suggestion, `need_type_info` is already good enough.

Special case `::<Vec<_>` suggestion for `Iterator::collect`.
    @estebank
    estebank committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    b3fba5e View commit details
    Browse the repository at this point in the history

  3. Mention implementations that satisfy the trait

    @estebank
    estebank committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    3e25bcb View commit details
    Browse the repository at this point in the history

  4. Suggest : Type instead of : _

    @estebank
    estebank committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    7d1e47a View commit details
    Browse the repository at this point in the history

  5. review comments

    @estebank
    estebank committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    165efab View commit details
    Browse the repository at this point in the history

  6. rename argument

    @estebank
    estebank committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    40a6275 View commit details
    Browse the repository at this point in the history